Make username case-insensitive

[MaxLeiter]

No description provided.

[coveralls]

Coverage remained the same at 73.554% when pulling 645c257 on MaxLeiter:case-sensitive into 3d533b3 on devsnd:devel.

[devsnd]

Yes, we should make them case insensitive, but before I can accept the PR we also have to make sure that changePassword, addUser and deleteUser are all also case insensitive. Otherwise bad things can happen.

If we're really careful we would check if there any users that would not be able to log in any more in that case (e.g. devsnd and DEVSND) on startup, but that's probably overkill.

[MaxLeiter]

I'll go ahead and put the lowers elsewhere, but this shouldn't stop anyone from logging in -- it just lowercases the username entered and the username it's fetching from the database

No point in making addUser case-insensitive, as it doesn't lookup usernames.

[MaxLeiter]

Updated, added to changePassword

[devsnd]

I'll go ahead and put the lowers elsewhere, but this shouldn't stop anyone from logging in -- it just lowercases the username entered and the username it's fetching from the database

Well, if anyone would create two users MAX and max then both could not log in anymore, because of line 108: assert len(rows) <= 1. So it's important to make sure that it's impossible to create this scenario by making all accesses lower-cased.

[MaxLeiter]

Good point -- done

[coveralls]

Coverage remained the same at 73.554% when pulling bcf3395 on MaxLeiter:case-sensitive into 3f969ef on devsnd:devel.

[coveralls]

Coverage decreased (-0.004%) to 73.551% when pulling 1a2de1b on MaxLeiter:case-sensitive into 3f969ef on devsnd:devel.

[devsnd]

Thanks, this time you get a dolphin and a fish, so you can feed it.

🐬 🐟