-
Notifications
You must be signed in to change notification settings - Fork 187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make username case-insensitive #677
Conversation
Yes, we should make them case insensitive, but before I can accept the PR we also have to make sure that If we're really careful we would check if there any users that would not be able to log in any more in that case (e.g. |
I'll go ahead and put the lowers elsewhere, but this shouldn't stop anyone from logging in -- it just lowercases the username entered and the username it's fetching from the database No point in making addUser case-insensitive, as it doesn't lookup usernames. |
Updated, added to changePassword |
Well, if anyone would create two users |
Good point -- done |
Thanks, this time you get a dolphin and a fish, so you can feed it. 🐬 🐟 |
No description provided.