Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve value checks #41

Merged
merged 3 commits into from
Apr 29, 2017
Merged

Improve value checks #41

merged 3 commits into from
Apr 29, 2017

Conversation

re1
Copy link

@re1 re1 commented Apr 26, 2017

Improve value checks on line 519 to avoid ZeroDivisionErrors.
Also update .gitignore to support Jetbrains IDEs.

@coveralls
Copy link

coveralls commented Apr 26, 2017 •
edited
Loading

Coverage Status

Coverage remained the same at 92.938% when pulling cb466d8 on re1:master into ad4cda0 on devsnd:master.

@devsnd
Copy link
Member

devsnd commented Apr 27, 2017

Hey Kojote!

Thanks a lot for your PR. I will merge it if you remove the ID3.samples_per_frame != 0 check, which is always True

Thanks again for your work :)

@coveralls
Copy link

coveralls commented Apr 27, 2017 •
edited
Loading

Coverage Status

Coverage remained the same at 92.938% when pulling 34475ee on re1:master into ad4cda0 on devsnd:master.

@devsnd devsnd merged commit fe5c720 into tinytag:master Apr 29, 2017
@devsnd
Copy link
Member

devsnd commented Apr 29, 2017

Hey Kojote,

Thanks again for your work!

Have a nice day, and also this cake 🍰

@devsnd devsnd mentioned this pull request Apr 29, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@re1 @coveralls @devsnd