Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): update dependency express to v4.19.2 [security] - autoclosed #810

Closed
wants to merge 1 commit into from

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Mar 29, 2024

Mend Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
express (source) 4.18.2 -> 4.19.2 age adoption passing confidence

GitHub Vulnerability Alerts

CVE-2024-29041

Impact

Versions of Express.js prior to 4.19.2 and pre-release alpha and beta versions before 5.0.0-beta.3 are affected by an open redirect vulnerability using malformed URLs.

When a user of Express performs a redirect using a user-provided URL Express performs an encode using encodeurl on the contents before passing it to the location header. This can cause malformed URLs to be evaluated in unexpected ways by common redirect allow list implementations in Express applications, leading to an Open Redirect via bypass of a properly implemented allow list.

The main method impacted is res.location() but this is also called from within res.redirect().

Patches

expressjs/express@0867302
expressjs/express@0b74695

An initial fix went out with express@4.19.0, we then patched a feature regression in 4.19.1 and added improved handling for the bypass in 4.19.2.

Workarounds

The fix for this involves pre-parsing the url string with either require('node:url').parse or new URL. These are steps you can take on your own before passing the user input string to res.location or res.redirect.

References

https://github.com/expressjs/express/pull/5539
https://github.com/koajs/koa/issues/1800
https://expressjs.com/en/4x/api.html#res.location


Release Notes

expressjs/express (express)

v4.19.2

Compare Source

==========

  • Improved fix for open redirect allow list bypass

v4.19.1

Compare Source

==========

  • Allow passing non-strings to res.location with new encoding handling checks

v4.19.0

Compare Source

v4.18.3

Compare Source

==========

  • Fix routing requests without method
  • deps: body-parser@1.20.2
    • Fix strict json error message on Node.js 19+
    • deps: content-type@~1.0.5
    • deps: raw-body@2.5.2

Configuration

📅 Schedule: Branch creation - "" (UTC), Automerge - At any time (no schedule defined).

🚦 Automerge: Enabled.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

@renovate renovate bot requested a review from a team as a code owner March 29, 2024 14:27
@renovate renovate bot added dependencies Pull requests that update a dependency file deps: javascript deps: minor labels Mar 29, 2024
Copy link
Contributor Author

renovate bot commented Mar 29, 2024

Branch automerge failure

This PR was configured for branch automerge. However, this is not possible, so it has been raised as a PR instead.

@renovate renovate bot force-pushed the renovate/npm-express-vulnerability branch from 13712bc to 6ba26c3 Compare April 2, 2024 12:43
@renovate renovate bot force-pushed the renovate/npm-express-vulnerability branch 5 times, most recently from 14cfc24 to 2621e89 Compare April 9, 2024 09:32
@renovate renovate bot force-pushed the renovate/npm-express-vulnerability branch 8 times, most recently from 17ae0fd to 66fcbea Compare May 14, 2024 12:09
@renovate renovate bot force-pushed the renovate/npm-express-vulnerability branch from 66fcbea to 1d9c1ce Compare May 25, 2024 11:07
@renovate renovate bot force-pushed the renovate/npm-express-vulnerability branch 4 times, most recently from 647a2f3 to 103d44e Compare June 13, 2024 05:01
@renovate renovate bot force-pushed the renovate/npm-express-vulnerability branch from 103d44e to 79589d9 Compare June 14, 2024 01:37
@renovate renovate bot force-pushed the renovate/npm-express-vulnerability branch from 79589d9 to 947ddaa Compare June 18, 2024 00:24
@renovate renovate bot changed the title fix(deps): update dependency express to v4.19.2 [security] fix(deps): update dependency express to v4.19.2 [security] - autoclosed Jun 18, 2024
@renovate renovate bot closed this Jun 18, 2024
@renovate renovate bot deleted the renovate/npm-express-vulnerability branch June 18, 2024 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file deps: javascript deps: minor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant