Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug: statemanager delete a State when uninstall failed. #82

Closed
daniel-hutao opened this issue Dec 28, 2021 · 1 comment · Fixed by #83
Closed

bug: statemanager delete a State when uninstall failed. #82

daniel-hutao opened this issue Dec 28, 2021 · 1 comment · Fixed by #83
Assignees
@daniel-hutao
Labels
bug Something isn't working
Milestone
v0.0.1

Comments

@daniel-hutao
Copy link
Member

Describe the Bug

statemanager delete a State when uninstall failed.

How to Reproduce

  1. install a plugin
  2. uninstall a plugin but failed with some error
  3. look into devstream.state file

Expected Behavior

state file hold the State with uninstall failed
@daniel-hutao daniel-hutao added the bug Something isn't working label Dec 28, 2021
This was referenced Dec 28, 2021
Merged
Closed
@daniel-hutao daniel-hutao self-assigned this Dec 28, 2021
@daniel-hutao daniel-hutao added this to the v0.1.0 milestone Dec 28, 2021
@lfbdev
Copy link
Contributor

lfbdev commented Dec 28, 2021

/lgtm

daniel-hutao added a commit that referenced this issue Dec 28, 2021
@daniel-hutao
Merge pull request #83 from daniel-hutao/bugfix
f75d062 
fix: #82 statemanager delete a State when uninstall failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@daniel-hutao daniel-hutao

Labels
bug Something isn't working
Projects
None yet
Milestone
v0.0.1
Development

Successfully merging a pull request may close this issue.

fix: #82 statemanager delete a State when uninstall failed
2 participants
@daniel-hutao @lfbdev