Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Cross-platform Build #123

Merged
merged 3 commits into from
Jan 12, 2022
Merged

Feat: Cross-platform Build #123

merged 3 commits into from
Jan 12, 2022

Conversation

IronCore864
Copy link
Member

@IronCore864 IronCore864 commented Jan 11, 2022

Summary

Description

This PR supports building dtm and its plugins in a cross-platform manner.

Src platform: darwin/arm64 (M1 Mac, aarch64)

Destination platforms Command to Build Method to Build Why
darwin/arm64 make build-darwin-arm64 local faster
darwin/amd64 make build-darwin-amd64 local faster
linux/amd64 make build-linux-amd64 container plugin cross-platform build in container is a must golang/go#22462

Other changes:

  • updated readme and makefile comments
  • created a build folder according to our project layout doc
  • make build-release that builds for all platforms, useful when releasing a new version for all platforms.

Related Issues

Resolves #18
Resolves #21

Screenshot

Test:

Screenshot 2022-01-11 at 12 17 18

@IronCore864 IronCore864 added the enhancement New feature or request label Jan 11, 2022
@IronCore864 IronCore864 added this to the v0.1.0 milestone Jan 11, 2022
@IronCore864 IronCore864 self-assigned this Jan 11, 2022
@IronCore864 IronCore864 changed the title Feat: Cross Platform Build Feat: Cross-platform Build Jan 11, 2022
@IronCore864 IronCore864 marked this pull request as ready for review January 11, 2022 04:09
@IronCore864
Copy link
Member Author

The docker image is in my personal docker hub; will create a new repo under Merico and move it there.

@IronCore864 IronCore864 added the documentation Improvements or additions to documentation label Jan 11, 2022
Makefile Outdated Show resolved Hide resolved
Copy link
Member

@daniel-hutao daniel-hutao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link
Contributor

@lfbdev lfbdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@IronCore864 IronCore864 merged commit 2c3d2d4 into main Jan 12, 2022
@IronCore864 IronCore864 deleted the feat-cross-platform-build branch January 12, 2022 02:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cross-platform build support Add containerized build support
3 participants