Skip to content
This repository has been archived by the owner on Jan 11, 2023. It is now read-only.

Getting setup on windows #1248

Closed
jasonLaster opened this issue Nov 18, 2016 · 17 comments
Closed

Getting setup on windows #1248

jasonLaster opened this issue Nov 18, 2016 · 17 comments

Comments

@jasonLaster
Copy link
Contributor

Hey, @viswanathamsantosh mind sharing some of the issues you were seeing getting setup with windows 10.

I imagine some of the potential issues could be with:

  • node
  • npm
  • yarn
  • lerna (symlinks)

Potentially hyperterm could help

CCing - @clarkbw @auchenberg @Garbee so they can help if there are concrete issues

@devcer
Copy link
Contributor

devcer commented Nov 18, 2016

yarn1
Running
Node 5.6
Npm 4.0.1
Yarn 0.16.1
but got this error!

@Garbee
Copy link
Contributor

Garbee commented Nov 18, 2016

The preinstall script is bash-only right now. So only UNIX systems can handle it. We need to investigate writing that script within node itself so we can make it platform-independent. This goes for all of the non-js bins we have.

@jasonLaster
Copy link
Contributor Author

@viswanathamsantosh try dropping the preinstall

diff --git a/package.json b/package.json
index 9f2444b..7543507 100644
--- a/package.json
+++ b/package.json
@@ -31,8 +31,7 @@
     "prepush": "npm run lint; node src/test/node-unit-tests.js --dots",
     "storybook": "start-storybook -p 6006",
     "build-storybook": "build-storybook",
-    "flow-coverage": "flow-coverage-report -i 'src/actions/*.js' -i 'src/reducers/*.js' -i 'src/utils/*.js' -t html -t text",
-    "preinstall": "./bin/preinstall"
+    "flow-coverage": "flow-coverage-report -i 'src/actions/*.js' -i 'src/reducers/*.js' -i 'src/utils/*.js' -t html -t text"
   },
   "dependencies": {
     "codemirror": "^5.1.0",

and then manually running

  npm i -g jasonlaster/lerna
  lerna bootstrap
  yarn install

@Garbee
Copy link
Contributor

Garbee commented Nov 19, 2016

Setting things up on a new system, the preinstall script is also failing on Linux machines. I had to do a manual npm i jasonlaster/lerna before yarn install would work.

@jasonLaster
Copy link
Contributor Author

Hmm. What was the error?
On Sat, Nov 19, 2016 at 9:20 AM Jonathan Garbee notifications@github.com
wrote:

Setting things up on a new system, the preinstall script is also failing
on Linux machines. I had to do a manual npm i jasonlaster/lerna before yarn
install would work.


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#1248 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAPiYo9j2iUEyp53UhuKzFVBoI3k-mv2ks5q_wWagaJpZM4K2u00
.

@Garbee
Copy link
Contributor

Garbee commented Nov 19, 2016

Line 8 of preinstall was causing the failure. I'll look into trying to make this script a thing of the past by building it into the package install flow in package.json. I don't see why it is necessary right off. By removing this we'll also get built-in Windows support to makes things easier there.

@jasonLaster
Copy link
Contributor Author

@Garbee perhaps we do postinstall: "lerna bootstrap"

@Garbee
Copy link
Contributor

Garbee commented Nov 19, 2016

Yup, looking into this now that the flexbox footer PR is updated.

@Garbee
Copy link
Contributor

Garbee commented Nov 19, 2016

PR #1264 is open for addressing that problem. Moving bootstrap to postinstall is exactly what was needed.

@jasonLaster
Copy link
Contributor Author

Closing this for now as i think it's addressed

@viswanathamsantosh please ping if you see other issues

@jasonLaster
Copy link
Contributor Author

jasonLaster commented Nov 21, 2016

Talked to @viswanathamsantosh offline and he mentioned issues with

`"C:\Program Files (x86)\Mozilla Firefox\firefox.exe" -start-debugger-server 6080 -P development`

I didn't get any error but the firefox didn't start either. Any thoughts?

c.c. @Garbee

@jasonLaster jasonLaster reopened this Nov 21, 2016
@Garbee
Copy link
Contributor

Garbee commented Nov 21, 2016

"C:\Program Files (x86)\Mozilla Firefox\firefox.exe" -start-debugger-server 6080 -P development

Perhaps --start-debugging-server ?

@jasonLaster
Copy link
Contributor Author

jasonLaster commented Nov 21, 2016

Also @auchenberg, @clarkbw thoughts?

Our docs recommend

C:\Program Files (x86)\Mozilla Firefox\firefox.exe -start-debugger-server 6080 -P development

and our driver has

@devcer
Copy link
Contributor

devcer commented Nov 21, 2016

--start-debugging-server worked perfectly for me now! Thank you jason. :D

@jasonLaster
Copy link
Contributor Author

oh great. perhaps we need to update the driver then to use two dashes. Mind making a PR for that so you can run

npm run firefox

We can discuss the tradeoffs in the PR

@clarkbw
Copy link
Contributor

clarkbw commented Nov 21, 2016

Also @clarkbw thoughts?

Strange, I thought we tested the single dash but now that I look at my windows box I can see it definitely needs the double dash.

Thanks for finding this!

@jasonLaster jasonLaster changed the title Getting setup on windows 10 Getting setup on windows Nov 28, 2016
@clarkbw
Copy link
Contributor

clarkbw commented Dec 17, 2016

Most of the issues here are fixed up. And as of #1309 npm run firefox works on Windows. I'm going to close this for now and we can open up a new issue to investigate further issues. Thanks a lot everyone!

@clarkbw clarkbw closed this as completed Dec 17, 2016
tommai78101 added a commit to tommai78101/debugger.html that referenced this issue Jun 19, 2017
Proposing a small change to the Firefox Windows command, based on firefox-devtools#1248, where using `--start-debugging-server` works while `-start-debugger-server` fails.
@firefox-devtools firefox-devtools deleted a comment from Romanbozeman Jan 16, 2019
@firefox-devtools firefox-devtools deleted a comment from Romanbozeman Jan 16, 2019
@firefox-devtools firefox-devtools deleted a comment from Romanbozeman Jan 16, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants