-
Notifications
You must be signed in to change notification settings - Fork 762
Getting setup on windows #1248
Comments
The preinstall script is bash-only right now. So only UNIX systems can handle it. We need to investigate writing that script within node itself so we can make it platform-independent. This goes for all of the non-js bins we have. |
@viswanathamsantosh try dropping the preinstall diff --git a/package.json b/package.json
index 9f2444b..7543507 100644
--- a/package.json
+++ b/package.json
@@ -31,8 +31,7 @@
"prepush": "npm run lint; node src/test/node-unit-tests.js --dots",
"storybook": "start-storybook -p 6006",
"build-storybook": "build-storybook",
- "flow-coverage": "flow-coverage-report -i 'src/actions/*.js' -i 'src/reducers/*.js' -i 'src/utils/*.js' -t html -t text",
- "preinstall": "./bin/preinstall"
+ "flow-coverage": "flow-coverage-report -i 'src/actions/*.js' -i 'src/reducers/*.js' -i 'src/utils/*.js' -t html -t text"
},
"dependencies": {
"codemirror": "^5.1.0", and then manually running
|
Setting things up on a new system, the preinstall script is also failing on Linux machines. I had to do a manual |
Hmm. What was the error?
|
Line 8 of |
@Garbee perhaps we do |
Yup, looking into this now that the flexbox footer PR is updated. |
PR #1264 is open for addressing that problem. Moving bootstrap to postinstall is exactly what was needed. |
Closing this for now as i think it's addressed @viswanathamsantosh please ping if you see other issues |
Talked to @viswanathamsantosh offline and he mentioned issues with
c.c. @Garbee |
Perhaps |
Also @auchenberg, @clarkbw thoughts? Our docs recommend
and our driver has |
|
oh great. perhaps we need to update the driver then to use two dashes. Mind making a PR for that so you can run
We can discuss the tradeoffs in the PR |
Strange, I thought we tested the single dash but now that I look at my windows box I can see it definitely needs the double dash. Thanks for finding this! |
Most of the issues here are fixed up. And as of #1309 |
Proposing a small change to the Firefox Windows command, based on firefox-devtools#1248, where using `--start-debugging-server` works while `-start-debugger-server` fails.
Hey, @viswanathamsantosh mind sharing some of the issues you were seeing getting setup with windows 10.
I imagine some of the potential issues could be with:
Potentially hyperterm could help
CCing - @clarkbw @auchenberg @Garbee so they can help if there are concrete issues
The text was updated successfully, but these errors were encountered: