Skip to content
This repository has been archived by the owner on Jan 11, 2023. It is now read-only.

[perf] Storing too much data into devtools.debugger.tabs pref #6546

Closed
janodvarko opened this issue Jun 25, 2018 · 3 comments
Closed

[perf] Storing too much data into devtools.debugger.tabs pref #6546

janodvarko opened this issue Jun 25, 2018 · 3 comments

Comments

@janodvarko
Copy link
Member

I am seeing the following warning when stepping:

Warning: attempting to write 16114 bytes to preference devtools.debugger.tabs. This is bad for general performance and memory usage. Such an amount of data should rather be written to an external file. This preference will not be sent to any content processes.

Fixing this should have positive impact on stepping performance.

Here is example value of the pref: https://pastebin.com/3ABGfm9X

Honza

@claim claim bot added the not-available label Jun 25, 2018
@janodvarko janodvarko changed the title Storing too much data into devtools.debugger.tabs pref [perf] Storing too much data into devtools.debugger.tabs pref Jun 25, 2018
@bomsy
Copy link
Contributor

bomsy commented Aug 8, 2018

/claim

@claim
Copy link

claim bot commented Aug 8, 2018

Thanks for claiming the issue! 👋

Here are some links for getting setup, contributing, and developing. We're always happy to answer questions in slack! If you become busy, feel free to /unclaim it.

🦊 Debugger team!

@darkwing
Copy link
Contributor

I made a rough sketch for a possible solution:

https://gist.github.com/darkwing/f8d5c430f1fd6f8dffd15d36ab57f10e

This is roughly the same strategy that @jasonLaster used when he introduced async storage:

8506987

@darkwing darkwing added the ucosp label Sep 5, 2018
@darkwing darkwing added this to Suggested Items in UCOSP Sep 18, 2018
@darkwing darkwing removed this from Suggested Items in UCOSP Sep 18, 2018
@janodvarko janodvarko mentioned this issue Oct 12, 2018
25 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants