Skip to content
This repository has been archived by the owner on Jan 11, 2023. It is now read-only.

The breakpoint gutter does not line up with the editor line #875

Closed
jasonLaster opened this issue Oct 4, 2016 · 8 comments
Closed

The breakpoint gutter does not line up with the editor line #875

jasonLaster opened this issue Oct 4, 2016 · 8 comments

Comments

@jasonLaster
Copy link
Contributor

Here's a good screenshot that illustrates where the gutter is slightly shorter than the line.

screen shot 2016-10-04 at 11 33 32 am

@monicau
Copy link
Contributor

monicau commented Oct 4, 2016

Hi Jason, I don't see any "first-timers-only" issues open at the moment. Can I grab this one?

@wldcordeiro
Copy link
Contributor

wldcordeiro commented Oct 4, 2016

@monicau Feel free to jump on this, the difficulty: easy tag generally means it is safe for first-timers as well, (speaking of the first-timers label, it might be worth removing in favor of just the easy label or renaming it 'very easy'? I don't like giving people the impression issues are for a group only, even if its to help newer contributors). Feel free to ask any questions.

@jlongster
Copy link
Contributor

Can't repro. When filing bugs, please state which browser and version you are using.

screen shot 2016-10-04 at 5 43 11 pm

@jasonLaster
Copy link
Contributor Author

Thanks @monicau.

Sorry @jlongster, I saw this in Chrome.

@monicau
Copy link
Contributor

monicau commented Oct 5, 2016

I modified the CSS to fix the gutter height, I also realigned the breakpoint svg arrow which also wasn't the same height as the line number highlighting. When doing the unit tests, there were some warnings. Is it something on my end?
debuggerunittestresult

@wldcordeiro
Copy link
Contributor

wldcordeiro commented Oct 5, 2016

@monicau Those aren't caused by you, they're appearing currently in master. I just read through your branch and since you have only CSS changes the only issues you would cause would be in npm run lint-css 👍

@monicau
Copy link
Contributor

monicau commented Oct 5, 2016

Thanks, that makes sense! I created a pull request.

@jasonLaster
Copy link
Contributor Author

Thanks @monicau. I just created an issue for cleaning this up :)

#886

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants