This repository has been archived by the owner on Jan 11, 2023. It is now read-only.
Type more utilities #1914
Merged
Type more utilities #1914
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clarkbw
reviewed
Feb 3, 2017
| @@ -6,15 +8,17 @@ const defer = require("../../defer"); | |||
| const { entries, toObject } = require("../../utils"); | |||
| const { executeSoon } = require("../../DevToolsUtils"); | |||
|
|
|||
| import type { ThunkArgs, ActionType } from "../../../actions/types"; | |||
|
|
|||
| const PROMISE = exports.PROMISE = "@@dispatch/promise"; | |||
| let seqIdVal = 1; | |||
There was a problem hiding this comment.
You could type this as a number
clarkbw
reviewed
Feb 3, 2017
| const PROMISE = exports.PROMISE = "@@dispatch/promise"; | ||
| let seqIdVal = 1; | ||
|
|
||
| function seqIdGen() { | ||
| function seqIdGen(): number { |
There was a problem hiding this comment.
And then you wouldn't need to type the function return here.
clarkbw
approved these changes
Feb 3, 2017
|
Still has some |
clarkbw
reviewed
Feb 9, 2017
| @@ -13,13 +35,13 @@ function prettyPrint({ url, indent, source }) { | |||
| mappings: prettified.map._mappings | |||
| }; | |||
| } catch (e) { | |||
| return new Error(`${e.message}\n${e.stack}`); | |||
| throw new Error(`${e.message}\n${e.stack}`); | |||
There was a problem hiding this comment.
This is an interesting change!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Associated Issue: #1785
Summary of Changes
This makes progress on some of the remaining util files. After this there are only a handful...
There are still some issues here, but it's most of the way there.
https://gist.github.com/e16ffd76edb9399d4ae00d5f4a9af139
CC @jbhoosreddy, @clarkbw you might be interested in taking a look at some of the redux stuff.