This repository has been archived by the owner on Jan 11, 2023. It is now read-only.
Add buckets for objects and keys #2026
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bomsy
approved these changes
Feb 15, 2017
jasonLaster
force-pushed
the
buckets
branch
2 times, most recently
from
9b12723
to
db00648
Compare
|
This is great if you ever deal with things like |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Associated Issue: #2025
Summary of Changes
This adds the logic for bucketing objects and arrays with lots of keys. It's still pretty rough, so it would be great to get some thoughts on how to clean it up.
Test Plan
Screenshots/Videos (OPTIONAL)