This repository has been archived by the owner on Jan 11, 2023. It is now read-only.
Stick the commandbar to the top of the seconday panel. #2128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2128 +/- ##
======================================
Coverage 0% 0%
======================================
Files 74 74
Lines 2328 2328
======================================
Misses 2328 2328Continue to review full report at Codecov.
|
irfanhudda
reviewed
Feb 24, 2017
| position: sticky; | ||
| top: 0; | ||
| z-index: 1; | ||
| background-color: white; |
There was a problem hiding this comment.
We should use some variable (--theme-body-background?) to make this work with all themes.
There was a problem hiding this comment.
oh right. Is that the var for the color? The naming scheme for them makes no sense so I have no clue what they are actually called.
There was a problem hiding this comment.
Updated, that wast he right variable name. Good catch!
Garbee
force-pushed
the
hotfix/commandbar-position
branch
from
e8cc1ea
to
cef648a
Compare
jasonLaster
approved these changes
Feb 24, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Associated Issue: #1918
Summary of Changes
.command-barto the top usingposition: sticky.Test Plan
Start up debugger, set a breakpoint, open the
windowscope variables. Scroll some.