This repository has been archived by the owner on Jan 11, 2023. It is now read-only.
Make close button appear correctly upon opening the conditional panel #2314
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2314 +/- ##
======================================
Coverage 0% 0%
======================================
Files 80 80
Lines 2489 2489
======================================
Misses 2489 2489
Continue to review full report at Codecov.
|
jasonLaster
reviewed
Mar 9, 2017
| @@ -32,6 +32,7 @@ | |||
|
|
|||
| .close-btn-big { | |||
| padding: 11px; | |||
| margin-right: 7px; | |||
There was a problem hiding this comment.
wouldn't this fail for a really long line?
There was a problem hiding this comment.
oh i see - that's nice.
jasonLaster
approved these changes
Mar 9, 2017
|
|
aklt
deleted the
conditional-breakpoint-panel-close-button-hidden-in-files-with-long-lines-2287
branch
jasonLaster
pushed a commit
that referenced
this pull request
Mar 10, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Associated Issue: #2287
This is a partial fix making the close button appear correctly upon opening of the conditional panel. It is still possible to cover the button by dragging the right panel over it, however. This does not always happen, but I was able to reproduce it.
When it becomes possible to catch drag events this issue should be revisited.
I also added a bit of space between the button and the right panel.
Test
CTRL-SHIFT-b to open the conditional panel. The close button should be visible
in the conditional panel to the right of the editor.