Use source map service from toolbox in Firefox #2506
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2506 +/- ##
==========================================
- Coverage 55.58% 54.99% -0.59%
==========================================
Files 39 39
Lines 1801 1813 +12
Branches 379 376 -3
==========================================
- Hits 1001 997 -4
- Misses 800 816 +16
Continue to review full report at Codecov.
|
| stopSourceMapWorker(); | ||
| stopPrettyPrintWorker(); | ||
| stopParserWorker(); | ||
| } |
There was a problem hiding this comment.
What's the rationale for moving this to bootstrap? I was thinking of doing the same thing, just curious.
There was a problem hiding this comment.
I thought it was helpful to see both bootstrap and teardown in the same file. For example with this change, we need to use the same Firefox conditional for the source map worker. With it all in one file, it's easy to see they work the same way.
| @@ -1,11 +1,12 @@ | |||
| // @flow | |||
|
|
|||
| /** | |||
| * Utils for mochitest | |||
| * Utils for Jest | |||
jryans
force-pushed
the
source-map-from-toolbox
branch
2 times, most recently
from
0d891b5
to
adbf644
Compare
src/actions/navigation.js
Outdated
| clearSourceMaps(); | ||
| clearDocuments(); | ||
| return async function({ dispatch, getState, client, sourceMaps }: ThunkArgs) { | ||
| sourceMaps.clearSourceMaps(); |
There was a problem hiding this comment.
Hmm, probably so since it goes through the worker messaging. I'll update it.
| let { frames, why, loadedObjects } = pauseInfo; | ||
| frames = await updateFrameLocations(frames); | ||
| frames = await updateFrameLocations(frames, sourceMaps); |
src/client/index.js
Outdated
|
|
||
| bootstrapWorker(); | ||
| bootstrapWorkers(); |
| menuOptions.push(jumpLabel); | ||
| } | ||
| // TODO: Find a new way to only add this for mapped sources? | ||
| menuOptions.push(jumpLabel); |
There was a problem hiding this comment.
yeah - this will be tough, the way we're doing it now. But that is okay. This will just be a no-op in the context menu.
| bootstrap(React, ReactDOM).then(onConnect); | ||
| window.L10N = L10N; | ||
| // $FlowIgnore: | ||
| window.L10N.setBundle(require("../assets/panel/debugger.properties")); |
|
|
||
| export function teardownWorkers() { | ||
| if (!isFirefoxPanel()) { | ||
| // When used in Firefox, the toolbox manages the source map worker. |
jryans
force-pushed
the
source-map-from-toolbox
branch
from
adbf644
to
dbc87db
Compare
Summary of Changes
sourceMapServiceobject from the toolbox, which manages the worker itself, etc. Those details are hidden from the debugger.Test Plan