This repository has been archived by the owner on Jan 11, 2023. It is now read-only.
query CM from the dom #2920
Merged
query CM from the dom #2920
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2920 +/- ##
=======================================
Coverage 59.94% 59.94%
=======================================
Files 63 63
Lines 2419 2419
Branches 497 497
=======================================
Hits 1450 1450
Misses 969 969Continue to review full report at Codecov.
|
juliandescottes
approved these changes
May 16, 2017
| @@ -741,3 +744,8 @@ function toggleCallStack(dbg) { | |||
| function toggleScopes(dbg) { | |||
| return findElement(dbg, "scopesHeader").click(); | |||
| } | |||
|
|
|||
| function getCM(dbg) { | |||
There was a problem hiding this comment.
nit: getCM is a bit opaque, getCodeMirror ?
There was a problem hiding this comment.
damn - missed this. CM is not great, but it's not terrible in context :)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes some issues referencing CM from the window