This repository has been archived by the owner on Jan 11, 2023. It is now read-only.
update mochitests #3202
Merged
update mochitests #3202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasonLaster
force-pushed
the
backbport-test
branch
from
867b865
to
cdd4ff2
Compare
Codecov Report
@@ Coverage Diff @@
## master #3202 +/- ##
=======================================
Coverage 47.61% 47.61%
=======================================
Files 98 98
Lines 4060 4060
Branches 838 838
=======================================
Hits 1933 1933
Misses 2127 2127Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #3202 +/- ##
==========================================
- Coverage 47.94% 47.61% -0.34%
==========================================
Files 98 98
Lines 4063 4060 -3
Branches 838 838
==========================================
- Hits 1948 1933 -15
- Misses 2115 2127 +12
Continue to review full report at Codecov.
|
codehag
reviewed
Jun 22, 2017
src/actions/sources.js
Outdated
| @@ -151,6 +151,7 @@ export function selectSourceURL( | |||
| ) { | |||
| return ({ dispatch, getState }: ThunkArgs) => { | |||
| const source = getSourceByURL(getState(), url); | |||
| debugger; | |||
src/test/integration/runner.js
Outdated
| @@ -67,7 +73,7 @@ describe("Tests", () => { | |||
|
|
|||
| it("editor gutter", async () => await editorGutter(ctx)); | |||
|
|
|||
| xit("editor highlight", async () => await editorHighlight(ctx)); | |||
| it.only("editor highlight", async () => await editorHighlight(ctx)); | |||
There was a problem hiding this comment.
i think we want this to just be "it"
| @@ -30,6 +30,8 @@ module.exports = async function(ctx) { | |||
| // place. | |||
| await waitForDispatch(dbg, "LOAD_SOURCE_TEXT"); | |||
|
|
|||
| debugger; | |||
There was a problem hiding this comment.
probably this debugger statement can go
jasonLaster
force-pushed
the
backbport-test
branch
from
cdd4ff2
to
6cd24df
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes