Skip to content
This repository has been archived by the owner on Jan 11, 2023. It is now read-only.

Fix editor search iteration #3546

Merged
merged 1 commit into from
Aug 3, 2017

Conversation

jasonLaster
Copy link
Contributor

Associated Issue: #1928

Summary of Changes

  • add a test
  • take modal out of the dom on close

@codecov
Copy link

codecov bot commented Aug 3, 2017

Codecov Report

Merging #3546 into master will decrease coverage by <.01%.
The diff coverage is 50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3546      +/-   ##
==========================================
- Coverage   51.86%   51.86%   -0.01%     
==========================================
  Files         119      119              
  Lines        4647     4649       +2     
  Branches      954      955       +1     
==========================================
+ Hits         2410     2411       +1     
- Misses       2237     2238       +1
Impacted Files Coverage Δ
src/components/SymbolModal.js 30.23% <50%> (+0.31%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update daebcfd...424d404. Read the comment docs.

@wldcordeiro wldcordeiro merged commit 4d0ff25 into firefox-devtools:master Aug 3, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants