This repository has been archived by the owner on Jan 11, 2023. It is now read-only.
Group Breakpoints Menu #4093
Merged
Group Breakpoints Menu #4093
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flodolo
reviewed
Sep 19, 2017
assets/panel/debugger.properties
Outdated
| breakpointMenuItem.removeCondition.accesskey=c | ||
| breakpointMenuItem.editCondition.label=Edit breakpoint condition | ||
| breakpointMenuItem.editCondition.accesskey=n | ||
| breakpointMenuItem.enableSelf2=Enable |
There was a problem hiding this comment.
since we're doing this change. can we switch to use .label
assets/panel/debugger.properties
Outdated
| breakpointMenuItem.enableAll2=Enable all | ||
| breakpointMenuItem.enableAll2.accesskey=b | ||
| breakpointMenuItem.disableAll2=Disable all | ||
| breakpointMenuItem.disableAll2.accesskey=k |
There was a problem hiding this comment.
there are a lot of other items in the context menu so it is tough to come up w/ one
|
It may be better to disable menu items than hide them if it creates a situation where a separator is the first item in the context menu. |
|
Oh nice, that's where it's coming from! |
jasonLaster
force-pushed
the
breakpoint-menu-cleanup
branch
from
1a22d48
to
1adb720
Compare
|
Awesome idea but still seeing a trailing separator:
Should we simply disable items that you're hiding? Seems a decent way for users to discover features of the menu, even if they aren't immediately applicable. |
|
that's okay, because we haven't finished "add condition". Once that's in there will always be a conditional item |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Old
New