This repository has been archived by the owner on Jan 11, 2023. It is now read-only.
always render connect message immediately & tweak styles #573
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r+ 👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I want to connect to node, I open the debugger and click on the "connect to node" link.
But the "not connected" message doesn't show until the Firefox connection times out. We should just go ahead and show the "not connected" message by default, and when it finds tabs it will re-render and show the normal tabs page. The
Tabscomponent is already listening to the tab state so all we need to do is render theTabscomponent immediately.I also updated the styles because the styles for the "not connected" component don't really apply on the main tabs page.