Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stack Chart has a different notion of categories than the Call Tree #1275

Closed
past opened this issue Sep 14, 2018 · 2 comments
Closed

Stack Chart has a different notion of categories than the Call Tree #1275

past opened this issue Sep 14, 2018 · 2 comments
Labels
categories Issues that relate to the frame categories polish Small features or changes that do not require planning to work on. These help out our end users. stack chart Issues related to the stack chart panel

Comments

@past
Copy link
Contributor

past commented Sep 14, 2018

wrong-category

The Stack Chart apparently needs to be taught about the new categories that were recently introduced in the Call Tree. The category for mach_msg_trap should be Idle, not Platform.
@julienw
Copy link
Contributor

julienw commented Sep 17, 2018

The "Category" displayed in the stack chart is actually the "implementation" (using the sidebar terminology) of the frame (eg: native / ion / etc), but using different words: "Platform" for "native", "JIT" for "ion", "JS Baseline" for "baseline" and "JS Interpeter" for "Interpreter"; which isn't even completely true as the "baseline" is already a JIT.
Also #764 is related here.

@julienw julienw added polish Small features or changes that do not require planning to work on. These help out our end users. stack chart Issues related to the stack chart panel categories Issues that relate to the frame categories labels Sep 17, 2018
@gregtatum
Copy link
Member

Yeah, this should be updated. I also think while we are at it, we should clarify our use of implementation. I filed #1276 to not muddy the discussion this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
categories Issues that relate to the frame categories polish Small features or changes that do not require planning to work on. These help out our end users. stack chart Issues related to the stack chart panel
Projects
None yet
Development

No branches or pull requests

3 participants