Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

For profiles with non-integer values, the values displayed in the sidebar are not properly rounded #1466

Closed
julienw opened this issue Nov 7, 2018 · 4 comments
Closed

For profiles with non-integer values, the values displayed in the sidebar are not properly rounded #1466

julienw opened this issue Nov 7, 2018 · 4 comments
Labels
assigned A developer has requested to work on this issue. bug Very important to fix, typically this means that the tool is broken or lying good first issue Good issue for new contributors, the issue must have clear instructions on how to complete the work help wanted Things ready to be worked on by anyone. Issues must include instructions on how to complete the task ready Issue has defined requirements. It can be grabbed and worked on sidebar Issues related to the sidebar panel

Comments

@julienw
Copy link
Contributor

julienw commented Nov 7, 2018

See:
image

We should build on the work in PR #1394 to display these values properly.
@julienw julienw added sidebar Issues related to the sidebar panel bug Very important to fix, typically this means that the tool is broken or lying help wanted Things ready to be worked on by anyone. Issues must include instructions on how to complete the task good first issue Good issue for new contributors, the issue must have clear instructions on how to complete the work ready Issue has defined requirements. It can be grabbed and worked on labels Nov 7, 2018
@julienw
Copy link
Contributor Author

julienw commented Nov 7, 2018

Here is an example profile: https://perf-html.io/public/404ff08ee5f412f355264601f12e5feff0ebaee6/calltree/?globalTrackOrder=6-1-2-3-4-0-5&hiddenGlobalTracks=1-2-3-4&localTrackOrderByPid=15249-1-0~15254-0~&range=10.0984_14.1128&thread=6&v=3

Here is the code that is responsible for this component: https://github.com/devtools-html/perf.html/blob/master/src/components/sidebar/CallTreeSidebar.js

@ghost
Copy link

ghost commented Nov 14, 2018

Hey wanted to work on this issue.

@julienw julienw added the assigned A developer has requested to work on this issue. label Nov 14, 2018
@julienw
Copy link
Contributor Author

julienw commented Nov 14, 2018

Hey @monikamaheshwari, sure, please do! :)

@ghost ghost mentioned this issue Nov 14, 2018
Closed
@ghost ghost mentioned this issue Dec 12, 2018
Closed
@julienw
Copy link
Contributor Author

julienw commented Feb 14, 2019

There's a PR at #1552 that's likely still valid and close to be finished. It needs a second review and a rebase.

julienw pushed a commit to julienw/perf.html that referenced this issue Feb 25, 2019
@maheshwarimonika @julienw
For profiles with non-integer values, the values displayed in the sid…
d7317df 
…ebar should be properly rounded

Fixes firefox-devtools#1466
julienw pushed a commit to julienw/perf.html that referenced this issue Feb 25, 2019
@maheshwarimonika @julienw
For profiles with non-integer values, properly round the values displ…
7bbdc75 
…ayed in the sidebar

Fixes firefox-devtools#1466
@julienw julienw mentioned this issue Feb 25, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
assigned A developer has requested to work on this issue. bug Very important to fix, typically this means that the tool is broken or lying good first issue Good issue for new contributors, the issue must have clear instructions on how to complete the work help wanted Things ready to be worked on by anyone. Issues must include instructions on how to complete the task ready Issue has defined requirements. It can be grabbed and worked on sidebar Issues related to the sidebar panel
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@julienw