For profiles with non-integer values, the values displayed in the sidebar should be properly rounded

[ghost]

This is an fix for issue #1466 .

[codecov]

Codecov Report

Merging #1491 into master will decrease coverage by 0.3%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #1491      +/-   ##
==========================================
- Coverage   81.02%   80.71%   -0.31%     
==========================================
  Files         159      157       -2     
  Lines       10823    10786      -37     
  Branches     2640     2623      -17     
==========================================
- Hits         8769     8706      -63     
- Misses       1858     1881      +23     
- Partials      196      199       +3

Impacted Files	Coverage Δ
src/components/sidebar/CallTreeSidebar.js	80.3% <100%> (-6.97%)	⬇️
src/profile-logic/call-tree.js	97.87% <100%> (ø)	⬆️
src/utils/format-numbers.js	84.31% <100%> (ø)	⬆️
src/components/app/UrlManager.js	3.7% <0%> (-80.17%)	⬇️
...mponents/network-chart/NetworkChartEmptyReasons.js	85.71% <0%> (-14.29%)	⬇️
src/app-logic/url-handling.js	81.72% <0%> (-2.04%)	⬇️
src/profile-logic/profile-data.js	84.31% <0%> (-1.54%)	⬇️
src/reducers/zipped-profiles.js	85.04% <0%> (-0.14%)	⬇️
src/actions/profile-view.js	90.14% <0%> (-0.11%)	⬇️
... and 17 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1abab9e...01dac62. Read the comment docs.

[julienw]

Hey @monikamaheshwari , thanks for the patch! I'm a bit confused because I see changes that come from your older PR #1394. I don't know why github shows them to me...

Maybe you should try to create another branch from latest master and report your changes on this new branch, and then create a separate PR.

[julienw]

Hey @monikamaheshwari, is this still something you'd like to finish? Thanks for your update :-)

[ghost]

Hey @julienw I want the functions from older PR for this issue. Can you help me with that.

[julienw]

You'll need to (what we call) rebase on top of master. This is how you can do it, if upstream is configured to the repository perf.html:

git fetch upstream
git rebase upstream/master

But you may need to remove the commits you don't need in the process, in that case the last command could be:

git rebase -i upstream/master

-i means that it will run in interactive mode: you'll be able to select which commits you want to keep while rebasing.

If you do something bad, don't worry as you can always come back at a previous version of your branch. This is possible using the command git reflog. The command shows all moves you did while being in your local repository. You can select one hash and run:

git reset --hard HASH

(replacing HASH with the right hash), to reset your working copy to a previous version.

You can read about all of this in https://git-scm.com/book/en/v2.