Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Memory track hover dot affects scrollable size in header #1639

Open
mstange opened this issue Jan 16, 2019 · 3 comments
Open

Memory track hover dot affects scrollable size in header #1639

mstange opened this issue Jan 16, 2019 · 3 comments
Labels
help wanted Things ready to be worked on by anyone. Issues must include instructions on how to complete the task polish Small features or changes that do not require planning to work on. These help out our end users. ready Issue has defined requirements. It can be grabbed and worked on timeline Issues related to the header timeline view

Comments

@mstange
Copy link
Contributor

mstange commented Jan 16, 2019

Steps to reproduce:

  1. Go to https://perfht.ml/2CpYC2S
  2. Scroll down in the header to the very bottom.
  3. Hover the memory track for Web Content (2/2) in the right half of the track, where the orange graph is very low.
  4. Without moving the mouse, scroll down.
  5. Unhover.

Expected results:
At step 4 you shouldn't be able to scroll down more.
So that step 5 doesn't make the header jerk.

┆Issue is synchronized with this Jira Task

@julienw julienw added polish Small features or changes that do not require planning to work on. These help out our end users. timeline Issues related to the header timeline view labels Jan 17, 2019
@mstange mstange added help wanted Things ready to be worked on by anyone. Issues must include instructions on how to complete the task ready Issue has defined requirements. It can be grabbed and worked on labels Jun 8, 2022
@mstange
Copy link
Contributor Author

mstange commented Jun 10, 2022

I think we need to make the graph overflow:hidden so that the dot doesn't extend beyond the graph's size. Additionally, we need to shift the graph itself a little bit inwards so that the dot isn't clipped off.
We already have code for this inward shifting:

// Add on half the stroke's line width so that it won't be cut off the edge
// of the graph.
const unitGraphCount = (accumulatedCounts[i] - minCount) / countRange;
y =
innerDeviceHeight -
innerDeviceHeight * unitGraphCount +
deviceLineHalfWidth;

@Tch4lla
Copy link

Tch4lla commented Sep 15, 2022

I've tried to reproduce this issue but I don't get the same expected results in my Firefox browser. Has it been resolved?

@mstange
Copy link
Contributor Author

mstange commented Sep 15, 2022

I can still reproduce this. Make sure that your mouse is in the "low" part of the orange graph while you scroll down, so that the "hover dot" is as low as possible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Things ready to be worked on by anyone. Issues must include instructions on how to complete the task polish Small features or changes that do not require planning to work on. These help out our end users. ready Issue has defined requirements. It can be grabbed and worked on timeline Issues related to the header timeline view
Projects
None yet
Development

No branches or pull requests

3 participants