Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build and Deployment pipeline > Proper validation and validation message for pipeline name #355

Open
uxarya-d opened this issue Mar 9, 2021 · 2 comments
Open

Build and Deployment pipeline > Proper validation and validation message for pipeline name #355

uxarya-d opened this issue Mar 9, 2021 · 2 comments
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@uxarya-d
Copy link
Contributor

uxarya-d commented Mar 9, 2021 •
edited

Summary

Build and deployment pipeline name field should have proper validation

Current behavior

  1. Proper validation does not exist for CI/build pipeline name
  2. If user enters something invalid error being shown is "Some required fields are missing" [Refer screenshot]

image

Expected behavior

  1. Proper input validation error message should be shown below the Pipeline Name field.
  2. "Some required fields are missing" toast message should not be shown in this case.

AB#279
@prakarsh-dt prakarsh-dt added the help wanted Extra attention is needed label May 24, 2021
@uxarya-d uxarya-d added the good first issue Good for newcomers label Sep 10, 2022
@kapishmalik
Copy link

@uxarya-d I would like to work on this issue.

@uxarya-d
Copy link
Contributor Author

@kapishmalik Sure. Let me revisit this and get back to you.

@uxarya-d uxarya-d changed the title Field validation Build and Deployment pipeline > Proper validation and validation message for pipeline name Jan 26, 2023
@prakarsh-dt prakarsh-dt mentioned this issue Aug 7, 2023
Merged
8 tasks
gireesh-devtron pushed a commit that referenced this issue Aug 13, 2023
@kartik-579 @Shubham9t9 @prakarsh-dt
feat: Kubectl proxy support (#355)
8eb1f74 
* added proxy url

* set proxy url for terminal session get request

* added logs

* updated proxyUrl field case

* updated proxy url field in cluster save/update apis

* updated proxy url validation

* wip

* removed redundant logs

* wip

* wip

* updated check in cluster save update apis for gitOps

* feat: workflow to validate PRs if an issue is linked or not (#3730)

* added github actions workflow to validate PRs if an issue is linked or not

* Update pr-issue-validator.yaml

* Update pr-issue-validator.yaml

* Update pr-issue-validator.yaml

---------

Co-authored-by: Shubham9t9 <shubhamkumar47022@gmai.com>
Co-authored-by: Prakarsh <71125043+prakarsh-dt@users.noreply.github.com>

* commented out path-ignore section in pr-issue-validator (#3739)

Co-authored-by: Shubham9t9 <shubhamkumar47022@gmai.com>

* chore: Update pr-issue-validator.yaml (#3740)

* Update pr-issue-validator.yaml

* Update pr-issue-validator.yaml

* Update pr-issue-validator.yaml

* Update pr-issue-validator.yaml

* Update pr-issue-validator.yaml

* Update pr-issue-validator.yaml

* Update pr-issue-validator.yaml

* Update pr-issue-validator.yaml

* Update pr-issue-validator.yaml

* wip

* updated informer obj

* chore: migration for kubectl proxy (#3731)

* added db scripts

* updated sql script

* updated  sql script no.

---------

Co-authored-by: Shubham Kumar <87755583+Shubham9t9@users.noreply.github.com>
Co-authored-by: Shubham9t9 <shubhamkumar47022@gmai.com>
Co-authored-by: Prakarsh <71125043+prakarsh-dt@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@kapishmalik @prakarsh-dt @uxarya-d