fix: Running Deployment status of applications in chart groups is not synced #3958
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos, SonarCloud Quality Gate passed!
|
kartik-579
approved these changes
Sep 22, 2023
prakash100198
added a commit
that referenced
this pull request
Oct 17, 2023
* setting scan enabled flag (#3925) * fix: revert app and workflow creation in case of error (#3923) * revert app and workflow creation * revert err value * check for update access while updating (#3936) * fix: cloning app with seq cd pipeline fix (#3926) * setting parent id and type in cd clone dto req. * ignoring parentid if parent is ci_pipeline type * mapping ref vs new cd pipeline in case of cloning app * minor fix * passing source to new pipeline id mapping and refpipline id with webhook type cd * minor fix * fix * external ci workflow cloning fix * minor fix * creating appWorkflow in app clone service layer rather than in pipelinebuilder for app clone * minor fixes * removing pointer map in cdPipelineConfigObject * further refactoring * minor fix * more refactoring * createWfMapping to createWfInstances * minor refactoring in AppCloneService * error handling * soft delete chart-group deployment * fix: Security Pagination Count wrong fix (#3950) * fix-pagination-count * Handling diff object type * Revert "soft delete chart-group deployment" This reverts commit 1be49e3. * fix: Base configmap get more precedence than override (#3940) * devtronContainerImageRepo varilable added * some test around cm/cs * some test around cm/cs for env * comments removed * changes done around secret * comments removed * refactoring around cm/cs merge * golang version updated in dockerfile * issue fixed after refactoring * refactoring for cm/cs * pointer issue handled * some refactoring around cm/cs and Dockerfile reverted * index removed * var name changed * fix: Pass/Failure Condition is not working as expected in pre build step. (#3938) * devtronContainerImageRepo varilable added * pass/fail condition issue fixed * fix: data not flowing into table ImageScanDeployInfo for triggers (#3946) * bug fix test * fixes * added migration script * removed commented code * added index back without unique constraint * removed virtual environments from unnecessary places (#3960) * soft delete chart-group deployment (#3958) * update wire injection * sql script number change --------- Co-authored-by: Shivam Nagar <124123645+Shivam-nagar23@users.noreply.github.com> Co-authored-by: Ashish-devtron <123808329+Ashish-devtron@users.noreply.github.com> Co-authored-by: ashish sonam <ashishsonam@devtron.ai> Co-authored-by: Aditya Ranjan <91401966+adi6859@users.noreply.github.com> Co-authored-by: subhashish-devtron <129164905+subhashish-devtron@users.noreply.github.com> Co-authored-by: Asutosh Das <asutosh2000ad@gmail.com> Co-authored-by: ashishdevtron <141303172+ashishdevtron@users.noreply.github.com> Co-authored-by: adi6859 <aditya.ar1909@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Running Deployment status of applications in chart groups is not synced. These changes fix the mentioned issue.
1: Create a chart group and add any 2 charts in the group .
2: deploy the chart group .
3: go to helm apps list page , you will see the apps you deployed though group .
4: delete those apps .
5: now again click on chart group , in running deployment section you can still see those apps you deleted .
6: click on delete icon of those apps , you will get warning no rows selected warning .
Expected : Apps should get removed from running deployment list of chart group
Fixes #
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist:
Does this PR introduce a user-facing change?