fix: Bugathon DT-19 version-2 fixes #4105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* revert app and workflow creation * revert err value
* setting parent id and type in cd clone dto req. * ignoring parentid if parent is ci_pipeline type * mapping ref vs new cd pipeline in case of cloning app * minor fix * passing source to new pipeline id mapping and refpipline id with webhook type cd * minor fix * fix * external ci workflow cloning fix * minor fix * creating appWorkflow in app clone service layer rather than in pipelinebuilder for app clone * minor fixes * removing pointer map in cdPipelineConfigObject * further refactoring * minor fix * more refactoring * createWfMapping to createWfInstances * minor refactoring in AppCloneService * error handling
…loyment-status-fix
* fix-pagination-count * Handling diff object type
This reverts commit 1be49e3.
* devtronContainerImageRepo varilable added * some test around cm/cs * some test around cm/cs for env * comments removed * changes done around secret * comments removed * refactoring around cm/cs merge * golang version updated in dockerfile * issue fixed after refactoring * refactoring for cm/cs * pointer issue handled * some refactoring around cm/cs and Dockerfile reverted * index removed * var name changed
…tep. (#3938) * devtronContainerImageRepo varilable added * pass/fail condition issue fixed
prakash100198
requested review from
vikramdevtron,
kripanshdevtron and
nishant-d
as code owners
vikramdevtron
previously approved these changes
Oct 16, 2023
|
Kudos, SonarCloud Quality Gate passed!
|
vikramdevtron
approved these changes
Oct 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
DT-19 v2 bug fixes
Fixes #4104
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist:
Does this PR introduce a user-facing change?