Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Deployment Template HCL parsing with % keyword #4012

Merged
merged 1 commit into from
Oct 4, 2023

Conversation

subhashish-devtron
Copy link
Contributor

@subhashish-devtron subhashish-devtron commented Oct 4, 2023

Description

Fixes #4009
The issue arose due to syntax conflict with HCL while parsing template for variables, which was in the format of %{some_value}

This syntax needed to be escaped before calling the parser so that HCL ignores this, since it was not intended by the user.
We made the current implementation of hcl parsing to also escape this format along with the already implemented escaping of the format @{some_value}

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Checklist:

  • The title of the PR states what changed and the related issues number (used for the release note).
  • Does this PR requires documentation updates?
  • I've updated documentation as required by this PR.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have tested it for all user roles.
  • I have added all the required unit/api test cases.

Does this PR introduce a user-facing change?


@sonarcloud
Copy link

sonarcloud bot commented Oct 4, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@subhashish-devtron subhashish-devtron changed the title fix: DT case for hcl parsing with percentage keyword fix: Deployment Template HCL parsing with % keyword Oct 4, 2023
@subhashish-devtron subhashish-devtron merged commit d29e963 into main Oct 4, 2023
7 checks passed
@subhashish-devtron subhashish-devtron deleted the fix-hcl-template-keyword branch October 4, 2023 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Deployment template does not allow saving when the http_code variable is present in the liveness command.
2 participants