Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: ci job handling in app create api #4054

Merged
merged 2 commits into from
Oct 10, 2023
Merged

fix: ci job handling in app create api #4054

merged 2 commits into from
Oct 10, 2023

Conversation

iamayushm
Copy link
Contributor

@iamayushm iamayushm commented Oct 10, 2023 •
edited
Loading

Description

Adding support for creating Creating job using api "/orchestrator/core/v1beta1/application".

Fixes #4055

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
test-cases

  • creating ci job
  • cloning app with ci-job
  • creating app with app create api

Checklist:

  • The title of the PR states what changed and the related issues number (used for the release note).
  • Does this PR requires documentation updates?
  • I've updated documentation as required by this PR.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have tested it for all user roles.
  • I have added all the required unit/api test cases.

Does this PR introduce a user-facing change?

@sonarcloud
Copy link

sonarcloud bot commented Oct 10, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@iamayushm iamayushm changed the title fix: ci job handling in app create api enhancement: ci job handling in app create api Oct 10, 2023
@iamayushm iamayushm changed the title enhancement: ci job handling in app create api fix: ci job handling in app create api Oct 10, 2023
@iamayushm iamayushm merged commit 7b8c7f3 into main Oct 10, 2023
15 of 18 checks passed
@iamayushm iamayushm deleted the ci_job_app_api branch October 10, 2023 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kartik-579 kartik-579 kartik-579 approved these changes

@kripanshdevtron kripanshdevtron kripanshdevtron approved these changes

@vikramdevtron vikramdevtron Awaiting requested review from vikramdevtron vikramdevtron is a code owner

@nishant-d nishant-d Awaiting requested review from nishant-d nishant-d is a code owner

Assignees
No one assigned
Labels
PR:Ready-to-Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat: ci job support in app create api
3 participants
@iamayushm @kartik-579 @kripanshdevtron