Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: clone cd pipelines while cloning app across project #4087

Merged
merged 5 commits into from
Oct 18, 2023
Merged

feat: clone cd pipelines while cloning app across project #4087

merged 5 commits into from
Oct 18, 2023

Conversation

Shivam-nagar23
Copy link
Member

@Shivam-nagar23 Shivam-nagar23 commented Oct 12, 2023 •
edited
Loading

Description

Fixes #1511
We are not cloning cd pipelines when cloning across different projects, enhancing it do the same

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Checklist:

  • The title of the PR states what changed and the related issues number (used for the release note).
  • Does this PR requires documentation updates?
  • I've updated documentation as required by this PR.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have tested it for all user roles.
  • I have added all the required unit/api test cases.

Does this PR introduce a user-facing change?

vikramdevtron
vikramdevtron previously approved these changes Oct 13, 2023
View reviewed changes
@Shivam-nagar23 Shivam-nagar23 changed the title enhancement: Clone cd pipeline while cloning app across project enhancement: clone cd pipelines while cloning app across project Oct 17, 2023
@Shivam-nagar23 Shivam-nagar23 changed the title enhancement: clone cd pipelines while cloning app across project feat: clone cd pipelines while cloning app across project Oct 17, 2023
@sonarcloud
Copy link

sonarcloud bot commented Oct 18, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell B 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@Shivam-nagar23 Shivam-nagar23 merged commit 9f2deaf into main Oct 18, 2023
4 of 5 checks passed
@Shivam-nagar23 Shivam-nagar23 deleted the clone-cd-across-project branch October 18, 2023 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vikramdevtron vikramdevtron vikramdevtron approved these changes

@kripanshdevtron kripanshdevtron Awaiting requested review from kripanshdevtron kripanshdevtron is a code owner

@nishant-d nishant-d Awaiting requested review from nishant-d nishant-d is a code owner

Assignees
No one assigned
Labels
PR:Ready-to-Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CD pipeline doesn't copied for clone application across project
2 participants
@Shivam-nagar23 @vikramdevtron