Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: pre-postcd trigger with plugin #4176

Merged
merged 11 commits into from
Oct 31, 2023
Merged

feat: pre-postcd trigger with plugin #4176

merged 11 commits into from
Oct 31, 2023

Conversation

Shivam-nagar23
Copy link
Member

@Shivam-nagar23 Shivam-nagar23 commented Oct 30, 2023 •
edited

Description

Fixes #4177

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Checklist:

  • The title of the PR states what changed and the related issues number (used for the release note).
  • Does this PR requires documentation updates?
  • I've updated documentation as required by this PR.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have tested it for all user roles.
  • I have added all the required unit/api test cases.

Does this PR introduce a user-facing change?

@Shivam-nagar23 Shivam-nagar23 changed the title fix: pre-postcd trigger fix with plugin feat: pre-postcd trigger fix with plugin Oct 30, 2023
@Shivam-nagar23 Shivam-nagar23 changed the title feat: pre-postcd trigger fix with plugin feat: pre-postcd trigger with plugin Oct 30, 2023
@sonarcloud
Copy link

sonarcloud bot commented Oct 31, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@Shivam-nagar23 Shivam-nagar23 merged commit d05fd2e into main Oct 31, 2023
5 checks passed
@Shivam-nagar23 Shivam-nagar23 deleted the fix-precd-trigger branch October 31, 2023 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vikramdevtron vikramdevtron vikramdevtron approved these changes

@kripanshdevtron kripanshdevtron Awaiting requested review from kripanshdevtron kripanshdevtron is a code owner

@nishant-d nishant-d Awaiting requested review from nishant-d nishant-d is a code owner

Assignees
No one assigned
Labels
PR:Ready-to-Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feature: Pre-postcd not triggering in case of pull images from CR Plugin
2 participants
@Shivam-nagar23 @vikramdevtron