Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix:rbac is not in sync with Actual application status #4237

Merged
merged 8 commits into from
Dec 6, 2023
Merged

fix:rbac is not in sync with Actual application status #4237

merged 8 commits into from
Dec 6, 2023

Conversation

adi6859
Copy link
Contributor

@adi6859 adi6859 commented Nov 14, 2023 •
edited
Loading

Description

rbac is not in sync with Actual application status

Fixes #4238

How Has This Been Tested?

  • Tests are performed locally.
  • Tests are also performed by deploying image on VM.

Checklist:

  • The title of the PR states what changed and the related issues number (used for the release note).
  • Does this PR requires documentation updates?
  • I've updated documentation as required by this PR.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have tested it for all user roles.
  • I have added all the required unit/api test cases.

Does this PR introduce a user-facing change?

@adi6859 adi6859 changed the title query modified in GetRolesForApp fix:rbac is not in sync with Actual application status Nov 14, 2023
kartik-579
kartik-579 previously approved these changes Dec 5, 2023
View reviewed changes
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Dec 5, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@adi6859 adi6859 merged commit 59f89d6 into main Dec 6, 2023
5 checks passed
@adi6859 adi6859 deleted the rbac-sync branch December 6, 2023 03:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kripanshdevtron kripanshdevtron kripanshdevtron approved these changes

@kartik-579 kartik-579 kartik-579 left review comments

@vikramdevtron vikramdevtron Awaiting requested review from vikramdevtron vikramdevtron is a code owner

@nishant-d nishant-d Awaiting requested review from nishant-d nishant-d is a code owner

Assignees
No one assigned
Labels
PR:Ready-to-Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: The number of apps assigned to manager doesn't update in a specific case
3 participants
@adi6859 @kartik-579 @kripanshdevtron