Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Gitbook assets moved to AWS S3 #4380

Merged
merged 2 commits into from
Dec 11, 2023
Merged

docs: Gitbook assets moved to AWS S3 #4380

merged 2 commits into from
Dec 11, 2023

Conversation

ashokdevtron
Copy link
Contributor

@ashokdevtron ashokdevtron commented Dec 11, 2023

Problem:
Several snapshots were present in the assets folder of Gitbook. This unnecessarily increases our repo size and makes it difficult to manage especially when we're already using AWS S3 to host images.

Changes Made:

  • Assets added to S3 (old assets folder has not been deleted)
  • Updated the old asset links with S3 links in the md files present inside /docs folder
  • Corrected the incorrect display of images in bulk edit doc

Copy link

sonarcloud bot commented Dec 11, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@prakarsh-dt prakarsh-dt merged commit 7567dcb into main Dec 11, 2023
7 checks passed
@prakarsh-dt prakarsh-dt deleted the asset-fix branch December 11, 2023 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants