-
Notifications
You must be signed in to change notification settings - Fork 458
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
perf: adding support for git cli operations for existing go-git flows #4602
Conversation
* removed unsued jira integration * removed test-suite-code * db migration conf removal * chore: removed unused injection * chore: removed dead code * added: migration script --------- Co-authored-by: Ash-exp <asutosh2000ad@gmail.com>
* moved chart-group in seperate code * removed unused dependency * removed dead code * extracted resource tree * moved notes * resource movement * removed unused code * removed unused dependency * commit methods * extracted status update * chore: clean up unused dead code * updated: EA mode docker file * updated: migration number --------- Co-authored-by: Ash-exp <asutosh2000ad@gmail.com>
…loyment-template-3
…loyment-template-2
…loyment-template-3
…loyment-template-2
…loyment-template-3
|
GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
---|---|---|---|---|---|
9257608 | Triggered | Base64 AWS keys | bf86180 | scripts/devtron-reference-helm-charts/deployment-chart_4-19-0/test-values.json | View secret |
9257608 | Triggered | Base64 AWS keys | ece3419 | scripts/devtron-reference-helm-charts/deployment-chart_4-19-0/test-values.json | View secret |
9257608 | Triggered | Base64 AWS keys | fe0f272 | scripts/devtron-reference-helm-charts/deployment-chart_4-19-0/test-values.json | View secret |
2763127 | Triggered | Generic High Entropy Secret | bf86180 | scripts/devtron-reference-helm-charts/deployment-chart_4-19-0/secrets-test-values.yaml | View secret |
2763127 | Triggered | Generic High Entropy Secret | bf86180 | scripts/devtron-reference-helm-charts/statefulset-chart_4-19-0/secrets-test-values.yaml | View secret |
2763127 | Triggered | Generic High Entropy Secret | fe0f272 | scripts/devtron-reference-helm-charts/deployment-chart_4-19-0/secrets-test-values.yaml | View secret |
2763127 | Triggered | Generic High Entropy Secret | ece3419 | scripts/devtron-reference-helm-charts/statefulset-chart_4-19-0/secrets-test-values.yaml | View secret |
2763127 | Triggered | Generic High Entropy Secret | fe0f272 | scripts/devtron-reference-helm-charts/statefulset-chart_4-19-0/secrets-test-values.yaml | View secret |
2763127 | Triggered | Generic High Entropy Secret | ece3419 | scripts/devtron-reference-helm-charts/deployment-chart_4-19-0/secrets-test-values.yaml | View secret |
141558 | Triggered | Generic High Entropy Secret | bf86180 | scripts/devtron-reference-helm-charts/statefulset-chart_4-19-0/env-values.yaml | View secret |
141558 | Triggered | Generic High Entropy Secret | fe0f272 | scripts/devtron-reference-helm-charts/statefulset-chart_4-19-0/env-values.yaml | View secret |
141558 | Triggered | Generic High Entropy Secret | ece3419 | scripts/devtron-reference-helm-charts/statefulset-chart_4-19-0/env-values.yaml | View secret |
141558 | Triggered | Generic High Entropy Secret | fe0f272 | scripts/devtron-reference-helm-charts/deployment-chart_4-19-0/env-values.yaml | View secret |
141558 | Triggered | Generic High Entropy Secret | ece3419 | scripts/devtron-reference-helm-charts/deployment-chart_4-19-0/env-values.yaml | View secret |
141558 | Triggered | Generic High Entropy Secret | bf86180 | scripts/devtron-reference-helm-charts/deployment-chart_4-19-0/env-values.yaml | View secret |
9404168 | Triggered | Username Password | 4f129c6 | internal/util/ArgoUtil/ArgoClient.go | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secrets safely. Learn here the best practices.
- Revoke and rotate these secrets.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
Our GitHub checks need improvements? Share your feedbacks!
…tore' into gitops-cli
7b8b017
to
5272d9e
Compare
Quality Gate passedIssues Measures |
PR is not linked to any issue, please make the corresponding changes in the body. |
Description
Fixes #4658
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist:
Does this PR introduce a user-facing change?