Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Refactoring deployment template GitOps #4615

Conversation

kartik-579
Copy link
Member

Description

Fixes #

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Checklist:

  • The title of the PR states what changed and the related issues number (used for the release note).
  • Does this PR requires documentation updates?
  • I've updated documentation as required by this PR.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have tested it for all user roles.
  • I have added all the required unit/api test cases.

Does this PR introduce a user-facing change?


kartik-579 and others added 30 commits January 11, 2024 12:59
* removed unsued jira integration

* removed test-suite-code

* db migration conf removal

* chore: removed unused injection

* chore: removed dead code

* added: migration script

---------

Co-authored-by: Ash-exp <asutosh2000ad@gmail.com>
* moved chart-group in seperate code

* removed unused dependency

* removed dead code

* extracted resource tree

* moved notes

* resource movement

* removed unused code

* removed unused dependency

* commit methods

* extracted status update

* chore: clean up unused dead code

* updated: EA mode docker file

* updated: migration number

---------

Co-authored-by: Ash-exp <asutosh2000ad@gmail.com>
@kartik-579 kartik-579 changed the title Refactoring deployment template GitOps chore: Refactoring deployment template GitOps Feb 1, 2024
Copy link

gitguardian bot commented Feb 1, 2024

⚠️ GitGuardian has uncovered 15 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
141558 Triggered Generic High Entropy Secret bf86180 scripts/devtron-reference-helm-charts/statefulset-chart_4-19-0/env-values.yaml View secret
141558 Triggered Generic High Entropy Secret bf86180 scripts/devtron-reference-helm-charts/deployment-chart_4-19-0/env-values.yaml View secret
141558 Triggered Generic High Entropy Secret ece3419 scripts/devtron-reference-helm-charts/statefulset-chart_4-19-0/env-values.yaml View secret
141558 Triggered Generic High Entropy Secret ece3419 scripts/devtron-reference-helm-charts/deployment-chart_4-19-0/env-values.yaml View secret
141558 Triggered Generic High Entropy Secret fe0f272 scripts/devtron-reference-helm-charts/statefulset-chart_4-19-0/env-values.yaml View secret
141558 Triggered Generic High Entropy Secret fe0f272 scripts/devtron-reference-helm-charts/deployment-chart_4-19-0/env-values.yaml View secret
2763127 Triggered Generic High Entropy Secret bf86180 scripts/devtron-reference-helm-charts/deployment-chart_4-19-0/secrets-test-values.yaml View secret
2763127 Triggered Generic High Entropy Secret bf86180 scripts/devtron-reference-helm-charts/statefulset-chart_4-19-0/secrets-test-values.yaml View secret
2763127 Triggered Generic High Entropy Secret ece3419 scripts/devtron-reference-helm-charts/statefulset-chart_4-19-0/secrets-test-values.yaml View secret
2763127 Triggered Generic High Entropy Secret ece3419 scripts/devtron-reference-helm-charts/deployment-chart_4-19-0/secrets-test-values.yaml View secret
2763127 Triggered Generic High Entropy Secret fe0f272 scripts/devtron-reference-helm-charts/deployment-chart_4-19-0/secrets-test-values.yaml View secret
2763127 Triggered Generic High Entropy Secret fe0f272 scripts/devtron-reference-helm-charts/statefulset-chart_4-19-0/secrets-test-values.yaml View secret
9257608 Triggered Base64 AWS keys bf86180 scripts/devtron-reference-helm-charts/deployment-chart_4-19-0/test-values.json View secret
9257608 Triggered Base64 AWS keys ece3419 scripts/devtron-reference-helm-charts/deployment-chart_4-19-0/test-values.json View secret
9257608 Triggered Base64 AWS keys fe0f272 scripts/devtron-reference-helm-charts/deployment-chart_4-19-0/test-values.json View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

Copy link

sonarcloud bot commented Feb 1, 2024

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

50 New issues
0 Security Hotspots
No data about Coverage
0.3% Duplication on New Code

See analysis details on SonarCloud

@kartik-579 kartik-579 merged commit 5272d9e into refactoring-template-gitOps-appStore Feb 1, 2024
5 checks passed
@kartik-579 kartik-579 deleted the refactoring-deployment-template-3-extend branch February 1, 2024 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants