-
Notifications
You must be signed in to change notification settings - Fork 469
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: AppStore Refactoring v3 #4621
Conversation
* removed unsued jira integration * removed test-suite-code * db migration conf removal * chore: removed unused injection * chore: removed dead code * added: migration script --------- Co-authored-by: Ash-exp <asutosh2000ad@gmail.com>
* moved chart-group in seperate code * removed unused dependency * removed dead code * extracted resource tree * moved notes * resource movement * removed unused code * removed unused dependency * commit methods * extracted status update * chore: clean up unused dead code * updated: EA mode docker file * updated: migration number --------- Co-authored-by: Ash-exp <asutosh2000ad@gmail.com>
…loyment-template-3
…loyment-template-2
…loyment-template-3
…loyment-template-2
…4595) (#4608) * prom code removal * removed test suites * chore: removed support for unused Prometheus and ArgoCd APIs * chore: app router and rest handler restructuring * removed redundant routings * fixed: sub path * Updated alias and added queries to AppList group router --------- Co-authored-by: nishant <nishant@devtron.ai>
|
GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
---|---|---|---|---|---|
141558 | Triggered | Generic High Entropy Secret | bf86180 | scripts/devtron-reference-helm-charts/statefulset-chart_4-19-0/env-values.yaml | View secret |
141558 | Triggered | Generic High Entropy Secret | bf86180 | scripts/devtron-reference-helm-charts/deployment-chart_4-19-0/env-values.yaml | View secret |
141558 | Triggered | Generic High Entropy Secret | ece3419 | scripts/devtron-reference-helm-charts/statefulset-chart_4-19-0/env-values.yaml | View secret |
141558 | Triggered | Generic High Entropy Secret | ece3419 | scripts/devtron-reference-helm-charts/deployment-chart_4-19-0/env-values.yaml | View secret |
141558 | Triggered | Generic High Entropy Secret | fe0f272 | scripts/devtron-reference-helm-charts/statefulset-chart_4-19-0/env-values.yaml | View secret |
141558 | Triggered | Generic High Entropy Secret | fe0f272 | scripts/devtron-reference-helm-charts/deployment-chart_4-19-0/env-values.yaml | View secret |
2763127 | Triggered | Generic High Entropy Secret | bf86180 | scripts/devtron-reference-helm-charts/deployment-chart_4-19-0/secrets-test-values.yaml | View secret |
2763127 | Triggered | Generic High Entropy Secret | bf86180 | scripts/devtron-reference-helm-charts/statefulset-chart_4-19-0/secrets-test-values.yaml | View secret |
2763127 | Triggered | Generic High Entropy Secret | ece3419 | scripts/devtron-reference-helm-charts/statefulset-chart_4-19-0/secrets-test-values.yaml | View secret |
2763127 | Triggered | Generic High Entropy Secret | ece3419 | scripts/devtron-reference-helm-charts/deployment-chart_4-19-0/secrets-test-values.yaml | View secret |
2763127 | Triggered | Generic High Entropy Secret | fe0f272 | scripts/devtron-reference-helm-charts/deployment-chart_4-19-0/secrets-test-values.yaml | View secret |
2763127 | Triggered | Generic High Entropy Secret | fe0f272 | scripts/devtron-reference-helm-charts/statefulset-chart_4-19-0/secrets-test-values.yaml | View secret |
6669481 | Triggered | PGP Private Key | ab5c595 | vendor/github.com/ProtonMail/go-crypto/openpgp/keys_test_data.go | View secret |
6669482 | Triggered | PGP Private Key | ab5c595 | vendor/github.com/ProtonMail/go-crypto/openpgp/keys_test_data.go | View secret |
6669483 | Triggered | PGP Private Key | ab5c595 | vendor/github.com/ProtonMail/go-crypto/openpgp/keys_test_data.go | View secret |
6669484 | Triggered | PGP Private Key | ab5c595 | vendor/github.com/ProtonMail/go-crypto/openpgp/keys_test_data.go | View secret |
9257608 | Triggered | Base64 AWS keys | bf86180 | scripts/devtron-reference-helm-charts/deployment-chart_4-19-0/test-values.json | View secret |
9257608 | Triggered | Base64 AWS keys | ece3419 | scripts/devtron-reference-helm-charts/deployment-chart_4-19-0/test-values.json | View secret |
9257608 | Triggered | Base64 AWS keys | fe0f272 | scripts/devtron-reference-helm-charts/deployment-chart_4-19-0/test-values.json | View secret |
9404168 | Triggered | Username Password | 93e635b | internal/util/ArgoUtil/ArgoClient.go | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secrets safely. Learn here the best practices.
- Revoke and rotate these secrets.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
Our GitHub checks need improvements? Share your feedbacks!
…tore' into chore-refactoring-v2
|
Description
App Store code refactoring V3
How Has This Been Tested?
Checklist:
Does this PR introduce a user-facing change?