chore: AppStore Refactoring v3 #4621

Ash-exp · 2024-02-02T09:34:38Z

Description

App Store code refactoring V3

How Has This Been Tested?

Sanity of App Store

Checklist:

The title of the PR states what changed and the related issues number (used for the release note).
Does this PR requires documentation updates?
I've updated documentation as required by this PR.
I have performed a self-review of my own code.
I have commented my code, particularly in hard-to-understand areas.
I have tested it for all user roles.
I have added all the required unit/api test cases.

Does this PR introduce a user-facing change?

* removed unsued jira integration * removed test-suite-code * db migration conf removal * chore: removed unused injection * chore: removed dead code * added: migration script --------- Co-authored-by: Ash-exp <asutosh2000ad@gmail.com>

* moved chart-group in seperate code * removed unused dependency * removed dead code * extracted resource tree * moved notes * resource movement * removed unused code * removed unused dependency * commit methods * extracted status update * chore: clean up unused dead code * updated: EA mode docker file * updated: migration number --------- Co-authored-by: Ash-exp <asutosh2000ad@gmail.com>

…loyment-template-3

…loyment-template-2

…loyment-template-3

…loyment-template-2

…4595) (#4608) * prom code removal * removed test suites * chore: removed support for unused Prometheus and ArgoCd APIs * chore: app router and rest handler restructuring * removed redundant routings * fixed: sub path * Updated alias and added queries to AppList group router --------- Co-authored-by: nishant <nishant@devtron.ai>

…factoring-v2

gitguardian · 2024-02-02T09:34:43Z

⚠️ GitGuardian has uncovered 20 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request

GitGuardian id	GitGuardian status	Secret	Commit	Filename
141558	Triggered	Generic High Entropy Secret	`bf86180`	scripts/devtron-reference-helm-charts/statefulset-chart_4-19-0/env-values.yaml	View secret
141558	Triggered	Generic High Entropy Secret	`bf86180`	scripts/devtron-reference-helm-charts/deployment-chart_4-19-0/env-values.yaml	View secret
141558	Triggered	Generic High Entropy Secret	`ece3419`	scripts/devtron-reference-helm-charts/statefulset-chart_4-19-0/env-values.yaml	View secret
141558	Triggered	Generic High Entropy Secret	`ece3419`	scripts/devtron-reference-helm-charts/deployment-chart_4-19-0/env-values.yaml	View secret
141558	Triggered	Generic High Entropy Secret	`fe0f272`	scripts/devtron-reference-helm-charts/statefulset-chart_4-19-0/env-values.yaml	View secret
141558	Triggered	Generic High Entropy Secret	`fe0f272`	scripts/devtron-reference-helm-charts/deployment-chart_4-19-0/env-values.yaml	View secret
2763127	Triggered	Generic High Entropy Secret	`bf86180`	scripts/devtron-reference-helm-charts/deployment-chart_4-19-0/secrets-test-values.yaml	View secret
2763127	Triggered	Generic High Entropy Secret	`bf86180`	scripts/devtron-reference-helm-charts/statefulset-chart_4-19-0/secrets-test-values.yaml	View secret
2763127	Triggered	Generic High Entropy Secret	`ece3419`	scripts/devtron-reference-helm-charts/statefulset-chart_4-19-0/secrets-test-values.yaml	View secret
2763127	Triggered	Generic High Entropy Secret	`ece3419`	scripts/devtron-reference-helm-charts/deployment-chart_4-19-0/secrets-test-values.yaml	View secret
2763127	Triggered	Generic High Entropy Secret	`fe0f272`	scripts/devtron-reference-helm-charts/deployment-chart_4-19-0/secrets-test-values.yaml	View secret
2763127	Triggered	Generic High Entropy Secret	`fe0f272`	scripts/devtron-reference-helm-charts/statefulset-chart_4-19-0/secrets-test-values.yaml	View secret
6669481	Triggered	PGP Private Key	`ab5c595`	vendor/github.com/ProtonMail/go-crypto/openpgp/keys_test_data.go	View secret
6669482	Triggered	PGP Private Key	`ab5c595`	vendor/github.com/ProtonMail/go-crypto/openpgp/keys_test_data.go	View secret
6669483	Triggered	PGP Private Key	`ab5c595`	vendor/github.com/ProtonMail/go-crypto/openpgp/keys_test_data.go	View secret
6669484	Triggered	PGP Private Key	`ab5c595`	vendor/github.com/ProtonMail/go-crypto/openpgp/keys_test_data.go	View secret
9257608	Triggered	Base64 AWS keys	`bf86180`	scripts/devtron-reference-helm-charts/deployment-chart_4-19-0/test-values.json	View secret
9257608	Triggered	Base64 AWS keys	`ece3419`	scripts/devtron-reference-helm-charts/deployment-chart_4-19-0/test-values.json	View secret
9257608	Triggered	Base64 AWS keys	`fe0f272`	scripts/devtron-reference-helm-charts/deployment-chart_4-19-0/test-values.json	View secret
9404168	Triggered	Username Password	`93e635b`	internal/util/ArgoUtil/ArgoClient.go	View secret

🛠 Guidelines to remediate hardcoded secrets

Understand the implications of revoking this secret by investigating where it is used in your code.
Replace and store your secrets safely. Learn here the best practices.
Revoke and rotate these secrets.
If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider

following these best practices for managing and storing secrets including API keys and other credentials
install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.

^{🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!}

…tore' into chore-refactoring-v2

sonarcloud · 2024-02-07T05:36:49Z

Quality Gate failed

Failed conditions

11.7% Duplication on New Code (required ≤ 3%)
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

kartik-579 and others added 30 commits January 11, 2024 12:59

removed registerInArgo multiple impls

c1ce9a5

extracted app metrics code

b8fa93b

migrated envLevel app metrics code to new service

e42180b

chart ref refactoring

9e36312

removed infra metrics db calls

a1421a5

moved app metrics repositories from /internal to /pkg

a6123c5

moved: const and types to bean

acfec88

removed: unused const

0eb82b7

review comments

765df77

Merge branch 'main' into refactoring-deployment-template-1

bf86180

migrated some methods from chartService to chartRefService

5038a0b

added dt validation service interface

c38d528

minor refactoring

f0e449e

Merge branch 'refactoring-deployment-template-2' into refactoring-dep…

23f28b2

…loyment-template-3

moved validation method - 1

c151a32

wip

20562f2

removed redundant appMetrics req obj

75b99ab

Merge branch 'refactoring-deployment-template-1' into refactoring-dep…

ece3419

…loyment-template-2

moved app metrics bindings to wireset

11f76ff

Merge branch 'refactoring-deployment-template-2' into refactoring-dep…

fe0f272

…loyment-template-3

removed multiple dead code

b59cb1c

remove redundant dependency

d113b35

moved ChartGroup router and rest handler to respective folder

ae90f36

stage 1

f802e61

gitOps refactoring

9c0f2b8

moved gitClient code to a common wrapper service

347e084

Merge branch 'main' into refactoring-deployment-template-1

14cf57a

Merge branch 'refactoring-deployment-template-1' into refactoring-dep…

d57ce3b

…loyment-template-2

Ash-exp and others added 9 commits January 30, 2024 18:20

Merge branch 'main' into refactoring-deployment-template-3-extend

0e3c265

Merge branch 'main' into chore-refactoring-v2

1499f31

Merge branch 'refactoring-deployment-template-3-extend' into chore-re…

e3b2344

…factoring-v2

chore: sanity after ent sync

23ac4a7

added: todo comment

a96ef3e

Merge branch 'chore-refactoring-v2' into chore-refactoring-v3

32e2566

added: todo comment

6df287a

Merge remote-tracking branch 'origin/main' into chore-refactoring-v3

98b25d2

Ash-exp added the enhancement New feature or request label Feb 2, 2024

Ash-exp self-assigned this Feb 2, 2024

Ash-exp requested review from vikramdevtron, kripanshdevtron and nishant-d as code owners February 2, 2024 09:34

github-actions bot added the PR:Ready-to-Review label Feb 2, 2024

Ash-exp added 9 commits February 5, 2024 12:27

Merge remote-tracking branch 'origin/refactoring-template-gitOps-appS…

9b39a8c

…tore' into chore-refactoring-v2

Merge remote-tracking branch 'origin/main' into chore-refactoring-v2

2bcef5f

chore: fixed gitops auto fix operations in upgrade helm charts

0bb64f8

added: nit pointer issue for argocd resource tree

799f9f1

fixed: nil poniter issue for gitops in upgrade deployment

50e1998

Merge branch 'chore-refactoring-v2' into chore-refactoring-v3

590b50b

Merge remote-tracking branch 'origin/main' into chore-refactoring-v3

3fa0224

Merge branch 'main' into chore-refactoring-v3

ab5c595

removed: comments

29a7d47

Ash-exp changed the title ~~chore: Refactoring v3~~ chore: AppStore Refactoring v3 Feb 7, 2024

nishant-d approved these changes Feb 7, 2024

View reviewed changes

Ash-exp merged commit 90c6c1a into main Feb 7, 2024
5 of 6 checks passed

Ash-exp deleted the chore-refactoring-v3 branch February 7, 2024 11:13

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: AppStore Refactoring v3 #4621

chore: AppStore Refactoring v3 #4621

Ash-exp commented Feb 2, 2024 •

edited

Loading

gitguardian bot commented Feb 2, 2024 •

edited

Loading

sonarcloud bot commented Feb 7, 2024

chore: AppStore Refactoring v3 #4621

chore: AppStore Refactoring v3 #4621

Conversation

Ash-exp commented Feb 2, 2024 • edited Loading

Description

How Has This Been Tested?

Checklist:

Does this PR introduce a user-facing change?

gitguardian bot commented Feb 2, 2024 • edited Loading

⚠️ GitGuardian has uncovered 20 secrets following the scan of your pull request.

sonarcloud bot commented Feb 7, 2024

Quality Gate failed

Ash-exp commented Feb 2, 2024 •

edited

Loading

gitguardian bot commented Feb 2, 2024 •

edited

Loading