Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added proxy in github transport #4652

Merged
merged 1 commit into from
Feb 9, 2024
Merged

feat: added proxy in github transport #4652

merged 1 commit into from
Feb 9, 2024

Conversation

kartik-579
Copy link
Member

@kartik-579 kartik-579 commented Feb 9, 2024

Description

Fixes #4656

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Checklist:

  • The title of the PR states what changed and the related issues number (used for the release note).
  • Does this PR requires documentation updates?
  • I've updated documentation as required by this PR.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have tested it for all user roles.
  • I have added all the required unit/api test cases.

Does this PR introduce a user-facing change?


Copy link

sonarcloud bot commented Feb 9, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@kartik-579 kartik-579 linked an issue Feb 9, 2024 that may be closed by this pull request
2 tasks
@kartik-579 kartik-579 merged commit 977690b into main Feb 9, 2024
4 of 5 checks passed
@kartik-579 kartik-579 deleted the gitops-proxy-fix branch February 9, 2024 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Not able to add github creds to set gitops Getting timeout error
2 participants