Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port QT UI to 0.13 base #5

Merged
merged 1 commit into from Nov 2, 2016

Conversation

zathras-crypto
Copy link

Initial PR for the port of the QT UI to 0.13 base.

Includes a simple interface for interacting with any-pair trading, but only intended to provide a reference for sending trades so I've kept it as close to the protocol as possible (no inverting to form a fake buy side for example).

Not perfect, and I'll keep working at some of the remaining bugs, but should provide a solid base to move forward from :)

@dexX7
Copy link
Owner

dexX7 commented Nov 1, 2016

Awesome!

There are two CLI commands undocumented (it's a new 0.13 feature to show a build failure for these):

  • -disclaimer
  • -omniuiwalletscope

For now I adopted the documentation from configuration.md and added it to init.cpp#L502, so maybe you could add those two there, too.

What's the status of this PR? Ready to merge? I haven't tested it yet. :)

@zathras-crypto
Copy link
Author

You should be able to safely merge yep, and you should be able to run and use it pretty well (there are no "gotchas" that I'm aware of - but there are some minor display issues like column sizing on balances tab, missing volume stats on metadex page, and a few other bits still "todo", but I'll submit fixes in the coming days.

Really I just wanted to get my work on it to date committed and PR'd so you could start playing with it too :)

@dexX7 dexX7 merged commit 3535ac8 into dexX7:13-port-stepwise Nov 2, 2016
dexX7 added a commit that referenced this pull request Nov 2, 2016
3535ac8 Port QT UI to 0.13 base (zathras-crypto)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants