Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for buggy OpenAI message types #38

Merged
merged 4 commits into from
Nov 8, 2023
Merged

Fix for buggy OpenAI message types #38

merged 4 commits into from
Nov 8, 2023

Conversation

transitive-bullshit
Copy link
Collaborator

I ran into multiple, unrelated type issues w/ different versions of OpenAI's latest message types.

There are definitely others issues that need to be created in the openai-node repo, but I decided to just simplify for now and make the ChatMessage type explicit since it's so crucial.

dexaai/dexter#7 depends on this

@transitive-bullshit transitive-bullshit mentioned this pull request Nov 8, 2023
Merged
rileytomasek
rileytomasek approved these changes Nov 8, 2023
View reviewed changes
Copy link
Collaborator

@rileytomasek rileytomasek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for cleaning up the official types :)

@transitive-bullshit transitive-bullshit merged commit ab15d75 into master Nov 8, 2023
6 checks passed
@transitive-bullshit transitive-bullshit deleted the fix/types branch November 8, 2023 03:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rileytomasek rileytomasek rileytomasek approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@transitive-bullshit @rileytomasek