backend: add absolute path to template links #520
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -13,7 +13,7 @@ <h2 class="heading">Log in to Your Account</h2> | |||
| <div class="form-row"> | |||
| <div class="input-desc"> | |||
| <label for="password">Password</label> | |||
| <span class="subtle-text input-label-right">Forgot? <a href="/send-reset-password?session_key={{ .SessionKey }}">Reset Password</a></span> | |||
| <span class="subtle-text input-label-right">Forgot? <a href="{{ absPath }}/send-reset-password?session_key={{ .SessionKey }}">Reset Password</a></span> | |||
There was a problem hiding this comment.
Isn't this wrong? E.g. if absPath returns /hi/ the URL path will be /hi//send-reset...
|
lgtm, squash then I'll merge on green |
fixes: #502 Add a new template function called `absPath` that converts relative paths to absolute paths based on the issuerURL. The template function can be used in templates like: ````html <a href="{{ .MyRelativePath | absPath }}"> ````
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: #502
WIP
Add a new template function called
absPaththat converts relativepaths to absolute paths based on the issuerURL. The template function
can be used in templates like:
or simply: