Allow dex to work at non base url #521
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@xaka has noted that most proxies trim the prefix of all paths. For instance the following nginx config trims Therefore, while URLs rendered in the HTML need to be absolute from the issuer URL, the actual paths that handlers are registered on shouldn't be. @alon-argus was wondering if you had any comments on this point. |
ericchiang
force-pushed
the
allow-dex-to-work-at-non-base-url
branch
from
c3c23f0
to
435cadf
Compare
|
Have gone through the local and gmail flows with registration and email verification. Think I got all the edge cases. |
|
Going to do another round of manual testing and add some documentation to the issuer flat. |
|
tested locally with http proxy, etc. so LGTM 👍 |
roidelapluie
added a commit
to roidelapluie/dex
that referenced
this pull request
Aug 15, 2016
The discovery URL has changed and now ends with /dex. As the scripts were updated in dexidp#525, the documentation was not. Broken since dexidp#521. [skip ci] Signed-off-by: Julien Pivotto <roidelapluie@inuits.eu>
remohammadi
added a commit
to remohammadi/dex
that referenced
this pull request
Sep 4, 2016
* In a9dce1c, the defaults are set to the `.example` paths, except for `emailer.json` which is instead committed into the git repository. So there's no need to duplicate those file in order to start dex-worker. * The default value for discovery is moved from `/` to `/dex` in dexidp#521 * Typo in `client-secret` value.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change updates #520 by having the handlers register using the issuerURL. It also updates the development environment by having the dex-worker and examle-app default to a non-base URL. This will hopefully catch any future bugs that assume operating from a root path.
Going to have to manually test all the connectors and registration flows :( Until then, do not merge.
Closes #502