api: adding a gRPC call for revoking refresh tokens. #802
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rithujohn191
force-pushed
the
token-revocation
branch
2 times, most recently
from
c786e4b
to
cf6232d
Compare
ericchiang
reviewed
Feb 15, 2017
server/api.go
Outdated
| return nil, err | ||
| } | ||
|
|
||
| offlineSessions, err := d.s.GetOfflineSessions(id.UserId, id.ConnId) |
There was a problem hiding this comment.
Why isn't this done in an Update?
There was a problem hiding this comment.
Changed this to an update operation
ericchiang
reviewed
Feb 15, 2017
server/api.go
Outdated
|
|
||
| // If the user has no more refresh tokens, the OfflineSession object should be cleaned up. | ||
| if len(offlineSessions.Refresh) == 0 { | ||
| if err := d.s.DeleteOfflineSessions(id.UserId, id.ConnId); err != nil { |
There was a problem hiding this comment.
Can we just keep this object around? Why delete it?
There was a problem hiding this comment.
Discussed offline and decided to keep the Offline Session object around even if the user does not have active refresh tokens. Might be helpful later on for auditing purposes.
|
thanks for the test. couple nits |
rithujohn191
force-pushed
the
token-revocation
branch
from
cf6232d
to
0bc79f1
Compare
ericchiang
reviewed
Feb 15, 2017
| // RevokeRefreshResp determines if the refresh token is revoked successfully. | ||
| message RevokeRefreshResp { | ||
| // Set to true is refresh token was not found and token could not be revoked. | ||
| bool not_found = 1; |
There was a problem hiding this comment.
Set this to true when UpdateOfflineSession returns err == storage.ErrNotFound.
rithujohn191
force-pushed
the
token-revocation
branch
from
0bc79f1
to
1ec19d4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a gRPC call that will enable users to revoke client specific refresh tokens.
Also added a test in api_test.go. Since we do not have APIs in place for creating refresh tokens and offline session objects, this has been done using the storage methods. If this test case seems like an overkill, I could get rid of it.