Supporting custom labels/annotations on deployment/pod #105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkroepke
force-pushed
the
custom-annotations
branch
2 times, most recently
from
d4c09a0
to
443b7b0
Compare
jkroepke
force-pushed
the
custom-annotations
branch
from
4c11179
to
876a717
Compare
jkroepke
force-pushed
the
custom-annotations
branch
from
876a717
to
a475807
Compare
|
@jkroepke this needs rebase as well |
Signed-off-by: Jan-Otto Kröpke <joe@cloudeteer.de>
jkroepke
force-pushed
the
custom-annotations
branch
3 times, most recently
from
e56324c
to
4597e91
Compare
|
@sagikazarmark rebased. |
|
@sagikazarmark can you please take a look here again? |
3 tasks
|
@sagikazarmark A friendly reminder. |
|
@sagikazarmark I would appreciate a review here, please let me know, if I can assist here. |
sagikazarmark
requested changes
Jun 20, 2023
charts/dex/values.yaml
Outdated
| @@ -107,8 +107,15 @@ rbac: | |||
| # If disabled, the operator is responsible for creating the necessary resources (ClusterRole and RoleBinding or CRD's) | |||
| createClusterScoped: true | |||
|
|
|||
| # -- Annotations to be added to deployment. | |||
| annotations: {} | |||
There was a problem hiding this comment.
How about deploymentAnnotations and deploymentLabels?
There was a problem hiding this comment.
good call, changed.
Signed-off-by: Jan-Otto Kröpke <mail@jkroepke.de> Signed-off-by: Jan-Otto Kröpke <joe@cloudeteer.de>
Signed-off-by: Jan-Otto Kröpke <joe@cloudeteer.de>
Signed-off-by: Jan-Otto Kröpke <joe@cloudeteer.de>
jkroepke
force-pushed
the
custom-annotations
branch
from
e01732f
to
3dd4a1d
Compare
|
@sagikazarmark I address all your points. |
sagikazarmark
requested changes
Jun 20, 2023
Co-authored-by: Márk Sági-Kazár <sagikazarmark@users.noreply.github.com> Signed-off-by: Jan-Otto Kröpke <github@jkroepke.de>
|
@sagikazarmark Applied, thanks for review! |
sagikazarmark
approved these changes
Jun 20, 2023
|
Thanks @jkroepke ! |
3 tasks
7 tasks
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Jan-Otto Kröpke joe@cloudeteer.de
Overview
Added the ability to define custom annotations on deployment/pods
Tools like https://github.com/stakater/Reloader depends on that.
What this PR does / why we need it
Special notes for your reviewer
Checklist
Chart.yaml(see the contributing guide for details)Chart.yaml(see the contributing guide for details)make docs