Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

URL using non ASCII characters [utf-8 support] #5

Closed
dgosset opened this issue Jan 31, 2015 · 4 comments
Closed

URL using non ASCII characters [utf-8 support] #5

dgosset opened this issue Jan 31, 2015 · 4 comments

Comments

@dgosset
Copy link

dgosset commented Jan 31, 2015

I think this old issue still up to date
http://code.google.com/p/sitemapgen4j/issues/detail?id=16
Even the sitemp is utf-8, we can't use url with french accents like éèà etc etc

I try the fix describe in the issue and it works.
http://code.google.com/p/sitemapgen4j/issues/detail?id=16

Best regards,
Denis
@mkurz
Copy link
Collaborator

mkurz commented Mar 17, 2015

@dgosset Could you please provide a pull request? Thanks!

dgosset pushed a commit to hoteia/sitemapgen4j that referenced this issue Mar 18, 2015
URL using non ASCII characters [utf-8 support] dfabulich#5
895cac1 
dfabulich#5 (comment)
@dgosset dgosset mentioned this issue Mar 18, 2015
Merged
@dgosset
Copy link
Author

dgosset commented Mar 18, 2015

done

dfabulich added a commit that referenced this issue Mar 24, 2015
@dfabulich
Merge pull request #6 from hoteia/master
c24db42 
URL using non ASCII characters [utf-8 support] #5
@mkurz
Copy link
Collaborator

mkurz commented Mar 24, 2015

Fixed in #6

@mkurz mkurz closed this as completed Mar 24, 2015
@mkurz
Copy link
Collaborator

mkurz commented Jun 13, 2015

@dgosset Your change has been included in todays v1.0.3 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dgosset @mkurz