Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get strip-components PR merged into camptocamp-archive #57

Closed
dfarrell07 opened this issue Feb 26, 2015 · 6 comments
Closed

Get strip-components PR merged into camptocamp-archive #57

dfarrell07 opened this issue Feb 26, 2015 · 6 comments

Comments

@dfarrell07
Copy link
Owner

I added the ability to pass the --strip-components flag to camptocamp-archive's tar extract step. Need to get my fork merged into the main project.

This is kind-of a blocker for merging the archive_mod branch into master, as Beaker can't puppet module install on host VMs from a git repo (only released mods on the Forge). Therefore, I can't point my Beaker tests at my pre-PR fork and use that until the PR is merged.

The code-level change in the PR seems to be solid. I've tested it on the archive_mod branch of vagrant-opendaylight.

Need to update the camptocamp-archive mod's docs to reflect the API change before I can submit the PR.

@dfarrell07
Copy link
Owner Author

Beaker can't puppet module install on host VMs from a git repo (only released mods on the Forge)

Note that I'm actively working with the Puppet community to fix either the PMT or Beaker to support this and similar use-cases. Here's a relevant Jira ticket.

@dfarrell07
Copy link
Owner Author

Need to update the camptocamp-archive mod's docs to reflect the API change before I can submit the PR.

Updated the docs in this commit.

Need to get my fork merged into the main project.

Submitted a PR, with a long and updated version of my notes on the change.

Now just waiting on the review and (hopefully) merge.

@dfarrell07
Copy link
Owner Author

Separating the rake tasks for our Beaker tests (#54: rake centos_tarball for a tarball install, rake centos is still an RPM install) made this a bit less pressing, as the RPM install Beaker tests are no longer broken by in-dev tarball install Beaker tests (#45).

@dfarrell07
Copy link
Owner Author

This is blocking #45, which is very painful. Can't create Beaker tests for the tarball install method until it's merged.

@dfarrell07
Copy link
Owner Author

I pinged my unmerged PR's thread, hoping to get some attention. No luck so far. Labeled this as blocked because it can't make progress without action from upstream camptocamp-archive folks.

@dfarrell07
Copy link
Owner Author

It was merged! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant