Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Warn user if casing of dst path is wrong #256

Closed
ben-edna opened this issue Dec 3, 2021 · 0 comments · Fixed by #269
Closed

Warn user if casing of dst path is wrong #256

ben-edna opened this issue Dec 3, 2021 · 0 comments · Fixed by #269
Labels
UX Not broken, but frustrating/unclear for users

Comments

@ben-edna
Copy link
Contributor

ben-edna commented Dec 3, 2021

On windows paths are case-insensitive. however the git commands rely on correct casing.
This could lead to hard to find issues.

Print out a warning when accessing the metadata if the path on disk has different casing than in the manifest.
@ben-edna ben-edna added the UX Not broken, but frustrating/unclear for users label Dec 3, 2021
ben-edna added a commit that referenced this issue Dec 20, 2021
@ben-edna
WIP: Check dst path
86f9c20 
- Fixes #256: Warn about casing
- Fixes #173: Warn about overlapping destinations
- Prevents CWE-22: Path traversal
@ben-edna ben-edna mentioned this issue Dec 20, 2021
Merged
ben-edna added a commit that referenced this issue Dec 21, 2021
@ben-edna
WIP: Check dst path
a1ca33e 
- Fixes #256: Warn about casing
- Fixes #173: Warn about overlapping destinations
- Prevents CWE-22: Path traversal
ben-edna added a commit that referenced this issue Dec 22, 2021
@ben-edna
Check dst path
98d0c29 
- Fixes #256: Warn about casing
- Fixes #173: Warn about overlapping destinations
- Prevents CWE-22: Path traversal
ben-edna added a commit that referenced this issue Dec 22, 2021
@ben-edna
Check dst path
02a4f25 
- Fixes #256: Warn about casing
- Fixes #173: Warn about overlapping destinations
- Prevents CWE-22: Path traversal
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
UX Not broken, but frustrating/unclear for users
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Check destination path before updating dfetch-org/dfetch
1 participant
@ben-edna