Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/project argument #196

Merged
merged 6 commits into from
Jul 19, 2021
Merged

Feature/project argument #196

merged 6 commits into from
Jul 19, 2021

Conversation

ben-edna
Copy link
Contributor

Fixes #188, add an optional positional argument for specifying projects in check and update commands.

@ben-edna ben-edna requested a review from jgeudens July 15, 2021 20:30
jgeudens
jgeudens reviewed Jul 16, 2021
View reviewed changes
dfetch/commands/check.py Outdated Show resolved Hide resolved
jgeudens
jgeudens reviewed Jul 16, 2021
View reviewed changes
Copy link
Contributor

@jgeudens jgeudens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding the projects option to the command line will be a very welcome feature.

The current concept seems good.

dfetch/manifest/manifest.py Show resolved Hide resolved
@ben-edna ben-edna merged commit 76a06a8 into main Jul 19, 2021
@ben-edna ben-edna deleted the feature/project-argument branch July 19, 2021 07:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jgeudens jgeudens jgeudens left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow for project argument in check and update commands
2 participants
@ben-edna @jgeudens