Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(FI-813) changed LedgerEnv to be a trait #127

Merged
merged 7 commits into from
Jul 13, 2023
Merged

feat(FI-813) changed LedgerEnv to be a trait #127

merged 7 commits into from
Jul 13, 2023

Conversation

NikolasHai
Copy link
Contributor

This MR introduces the following changes:

  • Change LedgerEnv to be a trait
  • Create the struct LedgerEnvReplica which connects to a running replica
  • Implement the trait LedgerEnv for the LedgerEnvReplica

roman-kashitsyn
roman-kashitsyn reviewed Jul 11, 2023
View reviewed changes
test/env/lib.rs Outdated Show resolved Hide resolved
roman-kashitsyn
roman-kashitsyn reviewed Jul 11, 2023
View reviewed changes
test/env/lib.rs Outdated Show resolved Hide resolved
roman-kashitsyn
roman-kashitsyn reviewed Jul 12, 2023
View reviewed changes
test/env/lib.rs Outdated Show resolved Hide resolved
test/env/lib.rs Outdated Show resolved Hide resolved
MarioDfinity
MarioDfinity reviewed Jul 12, 2023
View reviewed changes
test/env/lib.rs Outdated Show resolved Hide resolved
roman-kashitsyn
roman-kashitsyn approved these changes Jul 13, 2023
View reviewed changes
Copy link
Contributor

@roman-kashitsyn roman-kashitsyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

test/env/lib.rs Outdated Show resolved Hide resolved
test/env/lib.rs Outdated Show resolved Hide resolved
@NikolasHai NikolasHai merged commit 5da6b50 into main Jul 13, 2023
1 check passed
@NikolasHai NikolasHai deleted the FI-813-change-ledger-env-to-trait branch July 13, 2023 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarioDfinity MarioDfinity MarioDfinity left review comments

@roman-kashitsyn roman-kashitsyn roman-kashitsyn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@NikolasHai @roman-kashitsyn @MarioDfinity