chore: mergeback next -> identity-provider/2021-01-04 #216

gobengo · 2021-02-16T22:25:16Z

Trying ways of landing #208

Why?

feat(identity-provider): Identity Provider v1 #132 cannot be merged because it's not up to date with 'next' branch
This PR should fix that.

For now we just re-parse it in BigNumber.

This is a split from #132.

This includes a change to request_id from the identity-provider PR (#132) that I thought was related to something else, but is essential here with the new lerna packages. This moves the CI to using lerna entirely, and prevents running npm install (instead telling the user to run npx lerna bootstrap).

…to-132

gobengo · 2021-02-16T23:10:22Z

(Donno if we want lerna bootstrap to use hoist or not. But setting ci=true ensures that lerna won't try to write packages/*/package-lock.json

gobengo · 2021-02-16T23:15:48Z

I am skeptical of the * version ranges between intra-monorepo dependencies in packages/*/package.json... https://github.com/wixplosives/sample-monorepo/blob/master/packages/app/package.json#L18

gobengo · 2021-02-16T23:19:29Z

The npm ci scripts in agent,authentication try to run npm run build, but we should have those ci scripts expect build to have already been run by lerna run build in a dependency-tree-aware way. That way lerna can make sure that agent is built before authentication (otherwise it fails)

…o build

…ipt dep

hansl · 2021-02-16T23:35:47Z

Dont' waste too much time on this. In 132 you never built the websites using lerna, so using a * wildcard in lerna uncovers a lot of issues. We can fix tomorrow.

…n gh actions)

gobengo · 2021-02-16T23:40:35Z

so using a * wildcard in lerna uncovers a lot of issues. We can fix tomorrow.

Sounds like you're referring to lerna.json not packages/*/package.json

I am skeptical of the * version ranges between intra-monorepo dependencies in packages/*/package.json... https://github.com/wixplosives/sample-monorepo/blob/master/packages/app/package.json#L18

…ys know how to deal with lockfileVersion 2

…s own package-lock.json

… ci works)

gobengo · 2021-02-17T01:15:11Z

I am skeptical of the * version ranges between intra-monorepo dependencies in packages/*/package.json... https://github.com/wixplosives/sample-monorepo/blob/master/packages/app/package.json#L18

My skepticism was incorrect! Still feels odd to not have at least a major semver range in there (which I thought worked, but if this works too idc)

gobengo · 2021-02-17T01:17:35Z

lerna.json

-    "packages/authentication"
+    "packages/authentication",
+    "packages/bootstrap",
+    "e2e/*"


Notably this does not include other packages/*.

Those can be added after this merge, which is still a valid mergeback (and then some!) of next -> feat(identity-provider): Identity Provider v1 #132

next currently only has identity-provider on top of the ones explicitly enumerated here, and idp is brand new code we should be thrilled to just iterate on top of once feat(identity-provider): Identity Provider v1 #132 is merged

gobengo · 2021-02-17T01:18:36Z

lerna.json

+    "@typescript-eslint/parser",
+    "eslint",
+    "eslint-plugin-jsdoc",
+    "typescript"


These hoist devDependencies that lerna doesn't even try to install (lerna devs consider devDeps it out of scope), but that e.g. lerna run lint -> subpackage npm run lint will expect to be around, e.g. eslint.

Once this is merged, agent-js-devtools package can maybe completely go away?

it shoudln't be in next anymore.

…/agent-js into bengo/1613514044/132-mergeback-1

hansl and others added 14 commits February 16, 2021 11:06

feat: add support for bigint in leb128 (#200)

8aeb792

For now we just re-parse it in BigNumber.

chore: add more files to gitignore (#203)

bb07678

This is a split from #132.

Merge remote-tracking branch 'origin/next' into hansl/merge-master-in…

c2b7ec8

…to-132

fix auth-demo missing dep

4881b32

use the right versions of packages

18b58ba

fix tests for apps

60612d5

fix linting

4826f0e

.

3514f8d

rm subpackage package-lock.json

6a5be70

regenerate /package-lock.json without subpackage package-lock.json

5f4fb54

rm package-lock.json

e739e80

try explicitly opting-in packages to lerna

6323ad6

add hoist,ci to lerna.json

8a27e6f

gh nodejs-ci runs npm install

5299de3

gobengo added 4 commits February 16, 2021 15:22

fix npm install at monorepo now that subpackage ci scripts dont try t…

efcba4b

…o build

package.json devDeps on packages/agent-js-devtools to provide typescr…

5791c41

…ipt dep

see if lerna installs devtools as dep not devDep

85f58fc

Add typescript as monorepo devDep

0b7fec2

agent,bootstrap lint scripts dont call tslint (which isnt installed o…

e3aa294

…n gh actions)

gobengo added 5 commits February 16, 2021 15:46

monorepo doesnt do its own lint, it just does lerna run lint

7410a60

@dfinity/agent package.json includes types key

877801b

use lockfileVersion 1 since our github action for node 14 doesnt alwa…

ff45c69

…ys know how to deal with lockfileVersion 2

try with 'lerna bootstrap', ci=false, meaning each subpackage gets it…

883c65b

…s own package-lock.json

only use one version of typescript-eslint/eslint-plugin, not two

805a4c2

gobengo and others added 6 commits February 16, 2021 16:35

hoist eslint and use one version

bbfb6c4

hoist typescript

5f5a9fa

hoist eslint-plugin-jsdoc

64cf0b1

hoist @typescript-eslint/parser

b5b4473

disable new request_id sender_delegation test (will make it pass once…

f2f334b

… ci works)

rm file dependencies from /package.json (#217)

2af85e5

gobengo marked this pull request as ready for review February 17, 2021 01:15

gobengo commented Feb 17, 2021

View reviewed changes

gobengo requested a review from hansl February 17, 2021 01:27

This was referenced Feb 17, 2021

chore: rm playwright from hansl/merge-master-into-132 #212

Closed

feat(identity-provider): Identity Provider v1 #132

Merged

Merge branch 'identity-provider/2021-01-04' of github.com:dfinity-lab…

e29a93b

…/agent-js into bengo/1613514044/132-mergeback-1

hansl approved these changes Feb 17, 2021

View reviewed changes

gobengo merged commit 0ee52c2 into identity-provider/2021-01-04 Feb 17, 2021

gobengo mentioned this pull request Feb 18, 2021

feat: integrate with @dfinity/authentication to power authentication dfinity/cycles-wallet#24

Closed

gobengo mentioned this pull request Feb 25, 2021

chore: lerna.json enable authentication-demo #255

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: mergeback next -> identity-provider/2021-01-04 #216

chore: mergeback next -> identity-provider/2021-01-04 #216

gobengo commented Feb 16, 2021 •

edited

gobengo commented Feb 16, 2021

gobengo commented Feb 16, 2021

gobengo commented Feb 16, 2021

hansl commented Feb 16, 2021

gobengo commented Feb 16, 2021 •

edited

gobengo commented Feb 17, 2021

gobengo Feb 17, 2021

gobengo Feb 17, 2021 •

edited

hansl Feb 17, 2021

chore: mergeback next -> identity-provider/2021-01-04 #216

chore: mergeback next -> identity-provider/2021-01-04 #216

Conversation

gobengo commented Feb 16, 2021 • edited

gobengo commented Feb 16, 2021

gobengo commented Feb 16, 2021

gobengo commented Feb 16, 2021

hansl commented Feb 16, 2021

gobengo commented Feb 16, 2021 • edited

gobengo commented Feb 17, 2021

gobengo Feb 17, 2021

Choose a reason for hiding this comment

gobengo Feb 17, 2021 • edited

Choose a reason for hiding this comment

hansl Feb 17, 2021

Choose a reason for hiding this comment

gobengo commented Feb 16, 2021 •

edited

gobengo commented Feb 16, 2021 •

edited

gobengo Feb 17, 2021 •

edited