chore: lerna.json enable authentication-demo #255
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This got dropped during:
This is why I tried to deliver #132 before moving to lerna all the way. Moving all the way to lerna wasn't required to do pre-releases of authentication + agent. No one disagreed with this approach at the time.
Same caveats as two weeks ago and one week ago
Where does this leave the demos?
demos/sample-javascript
demos how to do authentication without@dfinity/bootstrap
identity
HttpAgent
->agent
auth.ic0.app
on cloudflaredfx@0.6.24
and its replica? (not overriding to use mercury)dfx new
modules likeic:canisters/{name}
, because they eval before canister js, and they use-and-never-rereadwindow.ic
demos/authentication-demo
demos how to do authentication with@dfinity/bootstrap
, which 100% of our partner developers use, and I believe this is the only reasonable way of 'a developer can' right now and on Monday, when I expect open-chat will integrate along one of these two paths, depending on whether they want to ship to Mercury or Sodium.@dfinity/bootstrap
has, for my whole time here (and I believe after SDK.2021.D), been responsible for loading before dev canister js, constructing anHttpAgent
, assigning it towindow.ic.agent
so all theic:canisters/{name}
modules use it when evald@dfinity/bootstrap
runs anIdentityActor
that boots before canister js, keeps track ofcurrentIdentity
, and handlesIdentityRequestedEvents
by updating the event dispatcher with thecurrentIdentity
as well as any subsequent identities changed to by canister jsauthenticator.useSession
or the resultingBootstrapChangeIdentityCommand
.next
(it is now after feat(identity-provider): Identity Provider v1 #132, but @stanleygjones hasn't accepted 35)Personally, I think devs are best off if we include both of these for now as we onboard people across sodium, mercury, beta, and more, and as implementation details of ic-fe, tungsten-bootstrap, etc. shift over time and according to organizational needs and plans.