Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: lerna.json enable authentication-demo #255

Merged
merged 2 commits into from
Feb 26, 2021

Conversation

gobengo
Copy link
Contributor

@gobengo gobengo commented Feb 25, 2021

This got dropped during:

This is why I tried to deliver #132 before moving to lerna all the way. Moving all the way to lerna wasn't required to do pre-releases of authentication + agent. No one disagreed with this approach at the time.

Same caveats as two weeks ago and one week ago

# until https://github.com/dfinity/dx-triage/issues/35#issuecomment-785329116
ln -s $HOME/dfinity/agent-js/apps/bootstrap/dist $(dfx cache show)/bootstrap

Where does this leave the demos?

Personally, I think devs are best off if we include both of these for now as we onboard people across sodium, mercury, beta, and more, and as implementation details of ic-fe, tungsten-bootstrap, etc. shift over time and according to organizational needs and plans.

@gobengo gobengo marked this pull request as ready for review February 25, 2021 23:00
@gobengo
Copy link
Contributor Author

gobengo commented Feb 25, 2021

@gobengo
Copy link
Contributor Author

gobengo commented Feb 25, 2021

@hansl If you can spare a sec before tomorrow's standup, will you please weigh in on anything that seems false in "Where does this leave the demos?" above?

@gobengo gobengo self-assigned this Feb 25, 2021
@hansl
Copy link
Contributor

hansl commented Feb 26, 2021

That IDP staging is old. You can either use the latest at https://auth.ic0.app/ or update the staging.

Also, you can use your own local one (it's only static files) by going in the identity-provider folder and running npm run develop.

@gobengo
Copy link
Contributor Author

gobengo commented Feb 26, 2021

That IDP staging is old. You can either use the latest at https://auth.ic0.app/ or update the staging.

My understanding is because of this (default identityProviderUrl of Authenticator is unsafeTemporaryIdentityProvider), but I'd hoped to change that s quite fast-follow of dx-triage#35.

The main thing is that the authentication-demo doesn't specify the identityProviderUrl, just uses the default, and I agree that in the medium term (closer to short...), I also want to see that more-beautiful https://auth.ic0.app. However, first I just want to land this how I authored it before https://auth.ic0.app started resolving :)

@gobengo gobengo merged commit df0996b into next Feb 26, 2021
@gobengo gobengo deleted the bengo/1614288984/authentication-demo branch February 26, 2021 05:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants