New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Removes Apps and Demos #329
Conversation
I'll block this for a week or two while we deprecate bootstrap, just in case there are issues where we need to republish it. Also workers depend on those two apps. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM just need to make sure we don't shoot ourselves in the foot. We still have two features incoming for the worker and bootstrap is still used as a fallback for ic0.app.
Agreed, there is no urgency here |
Okay, I think that we're ready to move forward, if the code looks good. Changes here are:
|
e2e/node/package.json
Outdated
"make:docs/reference": "", | ||
"publish:release": "", | ||
"test:coverage": "", | ||
"test": "jest" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There shouldn't be a test
script here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed, and I've removed "jest". However, I'll leave a blank script in case anyone wants to run tests using npm run test --workspaces
.
I'll also open up an issue on the npm github about skipping empty scripts. There's no reason we should have to include blank scripts in workspaces
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Good cleanup. Love it!
To focus the scope of agent-js, we are moving the identity provider into its own repo, which removes the need for IdentityProvider, Bootstrap, and our demos