-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: configure repo to run jest from root level #336
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hansl
reviewed
Apr 1, 2021
Now lerna is replaced for everything except running |
hansl
reviewed
Apr 5, 2021
hansl
reviewed
Apr 5, 2021
Also updates dfx version, and sets commands meant to be run with --workspaces to empty string in top-level package.json
hansl
approved these changes
Apr 5, 2021
krpeacock
added a commit
that referenced
this pull request
Apr 7, 2021
* deletes apps * removes demos, updates lerna * removes ic0.app * tests running from root * reverts testing changes * chore: configure repo to run jest from root level (#336) * restores node 12 * nulling "test" script so e2e doesn't run for unit tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now, running
npm run jest
ornpx jest
at the top level of the application will run tests for all packages, with a base-config at the root.Cleans up behavior around identities that was failing for tests executed via wallaby but wasn't throwing errors for straight jest